8000 Optionally build load scripts for multiple compilers/MPIs at the same time by xylar · Pull Request #379 · MPAS-Dev/compass · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Optionally build load scripts for multiple compilers/MPIs at the same time #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 27, 2022
Merged

Optionally build load scripts for multiple compilers/MPIs at the same time #379

merged 2 commits into from
Apr 27, 2022

Conversation

xylar
Copy link
Collaborator
@xylar xylar commented Apr 27, 2022

When you configure the compass environment, you can pass a list of compilers and a corresponding list of MPI libraries, or you
can pass "all" for one or both of these. If you leave either blank (or both), the default for the machine is used. If you pass "all" for either or both, only supported compiler/MPI pairs are used.

This merge also adds some missing combination of machines, compiler and MPI libraries to the list of unsupported configurations.

@xylar xylar added enhancement New feature or request dependencies and deployment Changes relate to creating conda and Spack environments, and creating a load script labels Apr 27, 2022
@xylar xylar self-assigned this Apr 27, 2022
@pep8speaks
Copy link
pep8speaks commented Apr 27, 2022 •
edited
Loading

Hello @xylar! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2022-04-27 10:42:45 UTC

xylar added 2 commits April 27, 2022 12:42
@xylar
Add support for a matrix of compilers/MPIs
6016605 
When you configure the compass environment, you can pass a list
of compilers and a corresponding list of MPI libraries, or you
can pass "all" for one or both of these.  If you leave either
blank (or both), the default for the machine is used.  If you
pass "all" for either or both, only supported compiler/MPI pairs
are used.
@xylar
Update unsupported configurations
1318df2
@xylar xylar force-pushed the add_load_script_matrix branch from bbe07ad to 1318df2 Compare April 27, 2022 10:42
@xylar
Copy link
Collaborator Author
xylar commented Apr 27, 2022

Testing

I have tested the --compiler all and --mpi all options on all 5 supported machines and my Linux laptop. I also tried various other combinations of flags (all for only one of --compiler or --mpi and lists for each as well as omitting one or both of these flags). Things seem to work as expected.

@xylar xylar merged commit 864ff9b into MPAS-Dev:master Apr 27, 2022
@xylar xylar deleted the add_load_script_matrix branch April 27, 2022 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@xylar xylar

Labels
dependencies and deployment Changes relate to creating conda and Spack environments, and creating a load script enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xylar @pep8speaks
0