8000 Constrain numpy < 2.0 by xylar · Pull Request #833 · MPAS-Dev/compass · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Constrain numpy < 2.0 #833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 30, 2024
Merged

Constrain numpy < 2.0 #833

merged 2 commits into from
Jun 30, 2024

Conversation

xylar
Copy link
Collaborator
@xylar xylar commented Jun 29, 2024 •
edited
Loading

For now, we need to constrain numpy < 2.0. Hopefully, we can update MPAS-Tools and compass to work with numpy >=2.0 in the near future.

Checklist

  • Document (in a comment titled Testing in this PR) any testing that was used to verify the changes

@xylar xylar added the dependencies and deployment Changes relate to creating conda and Spack environments, and creating a load script label Jun 29, 2024
@xylar
Copy link
Collaborator Author
xylar commented Jun 30, 2024

Testing

I ran the pr suite successfully on Chrysalis with Intel and Intel-MPI. With numpy 2.0, I was seeing failures related to numpy.string_, which was removed in v2.0.

@xylar xylar self-assigned this Jun 30, 2024
@xylar xylar merged commit c15a927 into MPAS-Dev:main Jun 30, 2024
4 checks passed
@xylar xylar deleted the constrain-numpy branch June 30, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@xylar xylar

Labels
dependencies and deployment Changes relate to creating conda and Spack environments, and creating a load script
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@xylar
0