8000 Add config_flowParamA_calculation = 'PB1982' to namelists by trhille · Pull Request #543 · MPAS-Dev/compass · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add config_flowParamA_calculation = 'PB1982' to namelists #543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 23, 2023
Merged

Add config_flowParamA_calculation = 'PB1982' to namelists #543

merged 4 commits into from
Feb 23, 2023

Conversation

trhille
Copy link
Collaborator
@trhille trhille commented Feb 23, 2023 •
edited
Loading

This is necessary to prevent an error that occurs when config_calving = 'von_Mises_stress' and config_flowParamA_calculation = 'constant'

Checklist

  • Document (in a comment titled Testing in this PR) any testing that was used to verify the changes
  • The MALI-Dev submodule has been updated with relevant MALI change

@trhille
Add config_flowParamA_calculation = 'PB1982' to humboldt namelist
779e62a 
This is necessary to prevent an error that occurs when
config_calving = 'von_Mises_stress' and config_flowParamA_calculation = 'constant'
@trhille trhille force-pushed the landice/add_flow_parama_to_humboldt_namelist branch from 055346f to 779e62a Compare February 23, 2023 15:55
@trhille
Copy link
Collaborator Author
trhille commented Feb 23, 2023

Testing

I tested this on Chicoma using load_dev_compass_1.2.0-alpha.4_chicoma-cpu_gnu_mpich_albany.sh and a MALI exe compiled at commit a9464e2. All tests passed successfully, whereas landice_humboldt_mesh-3km_restart_test_velo-fo_calving-von_mises_stress_damage-threshold_faceMelting was failing before adding this commit.

@trhille trhille changed the title Add config_flowParamA_calculation = 'PB1982' to humboldt namelist Add config_flowParamA_calculation = 'PB1982' to namelists Feb 23, 2023
@trhille
Add PB1982 flow param A calculation to calving tests
3a27b23 
Use config_flowParamA_calculation = '1982' in all compass tests that
use calving. This should currently only affect tests that use
config_calving = 'von_Mises_stress'.
@trhille
Copy link
Collaborator Author
trhille commented Feb 23, 2023 •
edited
Loading

Results of humboldt_calving_tests:

Test Runtimes:
00:07 PASS landice_humboldt_mesh-3km_decomposition_test_velo-none_calving-none
00:07 PASS landice_humboldt_mesh-3km_decomposition_test_velo-none_calving-floating
00:06 PASS landice_humboldt_mesh-3km_decomposition_test_velo-none_calving-eigencalving
00:07 PASS landice_humboldt_mesh-3km_decomposition_test_velo-none_calving-specified_calving_velocity
00:07 PASS landice_humboldt_mesh-3km_decomposition_test_velo-none_calving-von_mises_stress
00:07 PASS landice_humboldt_mesh-3km_decomposition_test_velo-none_calving-damagecalving
00:09 FAIL landice_humboldt_mesh-3km_decomposition_test_velo-none_calving-ismip6_retreat
00:06 FAIL landice_humboldt_mesh-3km_decomposition_test_velo-none_calving-von_mises_stress_damage-threshold_faceMelting
00:08 PASS landice_humboldt_mesh-3km_restart_test_velo-none_calving-none
00:08 PASS landice_humboldt_mesh-3km_restart_test_velo-none_calving-floating
00:08 PASS landice_humboldt_mesh-3km_restart_test_velo-none_calving-eigencalving
00:08 PASS landice_humboldt_mesh-3km_restart_test_velo-none_calving-specified_calving_velocity
00:08 PASS landice_humboldt_mesh-3km_restart_test_velo-none_calving-von_mises_stress
00:08 PASS landice_humboldt_mesh-3km_restart_test_velo-none_calving-damagecalving
00:03 FAIL landice_humboldt_mesh-3km_restart_test_velo-none_calving-ismip6_retreat
00:08 PASS landice_humboldt_mesh-3km_restart_test_velo-none_calving-von_mises_stress_damage-threshold_faceMelting
Total runtime 01:57
FAIL: 3 tests failed, see above.

The two ismip6_retreat tests have been failing, so that is unrelated to this PR.
landice_humboldt_mesh-3km_decomposition_test_velo-none_calving-von_mises_stress_damage-threshold_faceMelting fails validation because we need to add a halo update to the face-melting routine, which is a known issue that will be resolved posthaste.

@trhille
Copy link
Collaborator Author
trhille commented Feb 23, 2023 •
edited
Loading

Results of humboldt_calving_tests_fo:

Test Runtimes:
01:16 PASS landice_humboldt_mesh-3km_decomposition_test_velo-fo_calving-none
00:54 PASS landice_humboldt_mesh-3km_decomposition_test_velo-fo_calving-floating
01:04 PASS landice_humboldt_mesh-3km_decomposition_test_velo-fo_calving-eigencalving
01:05 PASS landice_humboldt_mesh-3km_decomposition_test_velo-fo_calving-specified_calving_velocity
01:12 FAIL landice_humboldt_mesh-3km_decomposition_test_velo-fo_calving-von_mises_stress
00:59 PASS landice_humboldt_mesh-3km_decomposition_test_velo-fo_calving-damagecalving
00:16 FAIL landice_humboldt_mesh-3km_decomposition_test_velo-fo_calving-ismip6_retreat
01:00 FAIL landice_humboldt_mesh-3km_decomposition_test_velo-fo_calving-von_mises_stress_damage-threshold_faceMelting
00:44 PASS landice_humboldt_mesh-3km_restart_test_velo-fo_calving-none
00:37 PASS landice_humboldt_mesh-3km_restart_test_velo-fo_calving-floating
00:40 PASS landice_humboldt_mesh-3km_restart_test_velo-fo_calving-eigencalving
00:39 PASS landice_humboldt_mesh-3km_restart_test_velo-fo_calving-specified_calving_velocity
00:43 PASS landice_humboldt_mesh-3km_restart_test_velo-fo_calving-von_mises_stress
00:39 PASS landice_humboldt_mesh-3km_restart_test_velo-fo_calving-damagecalving
00:06 FAIL landice_humboldt_mesh-3km_restart_test_velo-fo_calving-ismip6_retreat
00:35 PASS landice_humboldt_mesh-3km_restart_test_velo-fo_calving-von_mises_stress_damage-threshold_faceMelting
Total runtime 12:33
FAIL: 4 tests failed, see above.

ismip6_retreat and landice_humboldt_mesh-3km_decomposition_test_velo-fo_calving-von_mises_stress_damage-threshold_faceMelting fail for same reasons as above, so this is not a problem.

landice_humboldt_mesh-3km_decomposition_test_velo-fo_calving-von_mises_stress fails validation due to the L_inf value on time step 6 being about twice the allowable value, but still very small. Perhaps we should increase that threshold.

    Pass thresholds are:
       L1: 1.00000000000000e-11
       L2: 1.00000000000000e-11
       L_Infinity: 1.00000000000000e-12
calvingThickness     Time index: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
0:  l1: 0.00000000000000e+00  l2: 0.00000000000000e+00  linf: 0.00000000000000e+00
1:  l1: 3.53291506292874e-13  l2: 1.01748390806668e-13  linf: 5.68434188608080e-14
2:  l1: 2.73331535085696e-14  l2: 1.04947360618021e-14  linf: 8.77076189453874e-15
3:  l1: 8.94783379334907e-14  l2: 3.46084217529241e-14  linf: 2.84217094304040e-14
4:  l1: 3.67194339170873e-14  l2: 1.03276219408067e-14  linf: 5.32907051820075e-15
5:  l1: 4.43986210643676e-14  l2: 1.41351378176620e-14  linf: 1.11022302462516e-14
6:  l1: 2.16228012057951e-12  l2: 1.94250296307558e-12  linf: 1.94033678013739e-12
7:  l1: 3.84048261942160e-13  l2: 1.57451507687552e-13  linf: 1.24344978758018e-13
8:  l1: 2.68079829168766e-13  l2: 1.23963023396093e-13  linf: 9.28146448586631e-14
9:  l1: 2.90450823114963e-13  l2: 1.15208951028081e-13  linf: 8.12683254025615e-14
10:  l1: 7.55615188474668e-13  l2: 2.09014223329944e-13  linf: 9.05941988094128e-14
11:  l1: 6.51010495511528e-13  l2: 2.04330034501201e-13  linf: 1.06581410364015e-13
12:  l1: 8.83668138662586e-14  l2: 2.46759530964627e-14  linf: 1.15463194561016e-14
13:  l1: 3.43943623581922e-13  l2: 1.36726223184013e-13  linf: 9.85878045867139e-14
14:  l1: 6.80165992972270e-13  l2: 1.95862687888745e-13  linf: 9.28146448586631e-14
15:  l1: 2.45687151179119e-13  l2: 8.77850181188293e-14  linf: 5.06261699229071e-14
  FAIL /lustre/scratch4/turquoise/trhille/test_MALI-Dev_PR68/humboldt_calving_tests_fo/landice/humboldt/mesh-3km_decomposition_test/velo-fo_calving-von_mises_stress/16proc_run/output.nc
       /lustre/scratch4/turquoise/trhille/test_MALI-Dev_PR68/humboldt_calving_tests_fo/landice/humboldt/mesh-3km_decomposition_test/velo-fo_calving-von_mises_stress/32proc_run/output.nc

@trhille
Update MALI-Dev submodule to be able to build on Chicoma and Perlmutter
cc00bc6
@trhille
Increase calvingThickness difference tolerances
944c66b 
Increase calvingThickness difference tolerances by an order of
magnitude to allow for non-BFB behavior of Albany across different
numbers of processors.
matthewhoffman
matthewhoffman approved these changes Feb 23, 2023
View reviewed changes
Copy link
Member
@matthewhoffman matthewhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @trhille, for identifying and fixing this, which I seemed to have missed yesterday.

@matthewhoffman matthewhoffman merged commit 5eaed28 into MPAS-Dev:main Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewhoffman matthewhoffman matthewhoffman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trhille @matthewhoffman
0