8000 Add a recipe for OSU tidal prediction software by xylar · Pull Request #464 · MPAS-Dev/compass · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add a recipe for OSU tidal prediction software #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 1, 2022
Merged

Add a recipe for OSU tidal prediction software #464

merged 2 commits into from
Dec 1, 2022

Conversation

xylar
Copy link
Collaborator
@xylar xylar commented Nov 23, 2022 •
edited
Loading

This merge also adds the resulting otps conda package as a dependency.

otps is needed for #456

@xylar xylar added the dependencies and deployment Changes relate to creating conda and Spack environments, and creating a load script label Nov 23, 2022
@xylar xylar requested a review from sbrus89 November 23, 2022 17:36
@xylar xylar self-assigned this Nov 23, 2022
@xylar xylar force-pushed the add_otps_conda_recipe branch from 98047ec to e8ce7a5 Compare November 23, 2022 17:39
@xylar xylar force-pushed the add_otps_conda_recipe branch from 9b0f60c to dd8a8c4 Compare November 28, 2022 20:52
@xylar
Copy link
Collaborator Author
xylar commented Nov 28, 2022

@sbrus89, let me know if this is working for you now with my latest update. It worked for me on Chrysalis at least as far as creating the load script.

@sbrus89
Copy link
Collaborator
sbrus89 commented Nov 29, 2022

@xylar, yes this works for me now. I'm testing this with #456.

@sbrus89 sbrus89 mentioned this pull request Dec 1, 2022
Merged
@xylar
Copy link
Collaborator Author
xylar commented Dec 1, 2022

@sbrus89, are you able to approve this as a reviewer? Then, I can merge.

sbrus89
sbrus89 approved these changes Dec 1, 2022
View reviewed changes
Copy link
Collaborator
@sbrus89 sbrus89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this on Compy along with #456 and confirmed the analysis step (which uses this package) completes successfully. Thanks for your help with this, @xylar.

@xylar
Copy link
Collaborator Author
xylar commented Dec 1, 2022

Thanks @sbrus89!

@xylar xylar merged commit a7ef5b4 into MPAS-Dev:master Dec 1, 2022
@xylar xylar deleted the add_otps_conda_recipe branch December 1, 2022 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbrus89 sbrus89 sbrus89 approved these changes

Assignees

@xylar xylar

Labels
dependencies and deployment Changes relate to creating conda and Spack environments, and creating a load script
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xylar @sbrus89
0