Add a sigma vertical coordinate to ocean framework #442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this order, the limits are correct for a range that doesn't include zero.
TestingI ran the The results look as expected, e.g. here is a cross section of potential temperature: And here is the overturning streamfunction: |
|
@cbegeman, this is ready for you to review. I think all you need to do is describe the testing you've already done (since I believe you are already using this coordinate and the sigma versions of the ISOMIP+ test cases). |
cbegeman
approved these changes
Oct 28, 2022
|
Thanks for the review, @cbegeman! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge also adds ISOMIP+ test cases that demonstrate the usage of the coordinate.
In the process, a small bug was found in the ISOMIP+ visualization in which the colormap bounds were incorrectly including zero even for fields (like salinity) where this is not appropriate. This has also been fixed here for convenience.