Add comparison to default baroclinic channel #431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested this and it works as expected. @xylar on this and future compass PRs, I can assign the merge to me or you, whichever your prefer. |
xylar
approved these changes
Aug 30, 2022
There was a problem hiding this comment.
Thanks @mark-petersen! I've been wanting to have this for a long time. I'm approving by inspection and based on your testing.
Feel free to merge with the green button (after CI has finished)!
xylar
reviewed
Aug 30, 2022
|
Hello @mark-petersen! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2022-08-30 15:31:33 UTC |
xylar
reviewed
Aug 30, 2022
xylar
reviewed
Aug 30, 2022
|
@mark-petersen, once we get this right, please squash all these fixups. |
7222910 to
900375f
Compare
|
Retested with squashed commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default baroclinic channel test case was missing the comparison step. This is the first test in the nightly suite, so it is useful to immediately see if the comparison is working.