8000 Give log path for failed tests only in suite by xylar · Pull Request #423 · MPAS-Dev/compass · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Give log path for failed tests only in suite #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 13, 2022
Merged

Give log path for failed tests only in suite #423

merged 2 commits into from
Jul 13, 2022

Conversation

xylar
Copy link
Collaborator
@xylar xylar commented Jul 13, 2022 •
edited
Loading

When test cases are run on their own, they don't put a log file in case_outputs so we shouldn't incorrectly point to one.

This merge also clean things up by converting calls to the .format() method to f-strings.

closes #398

@xylar xylar added bug Something isn't working clean-up labels Jul 13, 2022
@xylar xylar self-assigned this Jul 13, 2022
@pep8speaks
Copy link
pep8speaks commented Jul 13, 2022 •
edited
Loading

Hello @xylar! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2022-07-13 11:48:36 UTC

xylar added 2 commits July 13, 2022 13:48
@xylar
Switch run/serial module to use f-strings
981c270
@xylar
Give log path for failed tests only in suite
ead3f71 
When test cases are run on their own, they don't put a log file
in `case_outputs` so we shouldn't incorrectly point to one.
@xylar xylar force-pushed the fix_log_path_in_error branch from 0ec2753 to ead3f71 Compare July 13, 2022 11:48
@xylar
Copy link
Collaborator Author
xylar commented Jul 13, 2022

Testing

I ran the nightly test suite on Linux with Gnu compilers and saw the normal output (all tests passed).

I ran a single test in its work directory (deliberately causing it to fail) and saw the expected stack trace and error message but not the message about a log file in case_output.

@xylar xylar merged commit bf29cdc into MPAS-Dev:master Jul 13, 2022
@xylar xylar deleted the fix_log_path_in_error branch July 13, 2022 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@xylar xylar

Labels
bug Something isn't working clean-up framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect log file message when running individual testcase
2 participants
@xylar @pep8speaks
0