Several updates to ocean transects #613
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeabbe4 to
9a38b60
Compare
9a38b60 to
6b9af29
Compare
The primary change is that transects are plotted using quads, rather than triangles. This has various advantages: * quads are more intuitive * we can plot contours with labels * the `matplotlib` functionality for plotting fields on quads is a lot more robust, mature, and intuitive than that for triangles This merge also adds some missing documentation on public transect-related functions.
If a vertical coordinate for a gridded transect is supplied, interpolation weights are pre-computed that allow interpolation from the original transect to the corresponding MPAS-Ocean transect nodes. This is useful for comparing observations or other data fields with MPAS-Ocean values.
These are fields with dimension `nVertLevelsP1`.
6b9af29 to
397b4d4
Compare
TestingI tested these in both Polaris (E3SM-Project/polaris#295) and MPAS-Analysis (MPAS-Dev/MPAS-Analysis#1085). Things seem to be working as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge adds support for:
nVertLevelsP1as the vertical dimensionmatplotlibfunctionality for plotting fields on quadsis a lot more robust, mature, and intuitive than that for triangles
This pull request includes significant changes to the documentation and code structure related to transect plotting and interpolation in the
mpas_toolspackage. The changes involve updates to the documentation to reflect the new module structure, the addition of new functions, and the removal of outdated code.Documentation Updates:
conda_package/docs/api.rstto reflect changes in module names and added new functions for transect plotting and interpolation. [1] [2]conda_package/docs/ocean/visualization.rstandconda_package/docs/visualization.rst. [1] [2]Code Structure Changes:
plot_ocean_transectsfunction and related code fromconda_package/mpas_tools/ocean/viz/transects.py.conda_package/mpas_tools/ocean/viz/transect/__init__.py.Test Updates:
conda_package/mpas_tools/tests/test_viz_transects.pyto use the new module structure and functions for transect-related tests.