setup: always copy subdirs ocean, landice,... #550
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If changes are made to the scripts in these directories running `python -m pip install -e conda_package` will not update them. This change removes the directory existence check so that they are always copied. copytree will not overwrite, so we need to delete the existing dir first.
e95f589 to
af6730a
Compare
xylar
approved these changes
Jan 29, 2024
There was a problem hiding this comment.
@cwsmith, this looks great
I tested it out with:
conda create -y -n test mpas_tools
conda activate test
python -m pip install -e conda_package/
Then, I modified landice/mesh_tools_li/tune_ismip6_melt_deltat.py, ran:
python -m pip install -e conda_package/
again and verified that conda_package/landice/mesh_tools_li/tune_ismip6_melt_deltat.py contained the changes.
|
@cwsmith, this will appear in the next release but likely won't make it into Compass immediately because I think we pin a specific version. Hopefully, that won't affect you because presumably your development branches will always start from the MPAS-Tools |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If changes are made to the scripts in these directories running
python -m pip install -e conda_packagewill not update them. This change removes the directory existence check so that they are always copied.Thanks to @xylar for the pointer on the fix for this.
closes #549