8000 Fix docs for coastline alteration by xylar · Pull Request #546 · MPAS-Dev/MPAS-Tools · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix docs for coastline alteration #546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

xylar
Copy link
Collaborator
@xylar xylar commented Jan 4, 2024

They were using the old (C++ based) mask creator but need to be updated to use functions in mpas_tools.mesh.mask now that the mpas_tools.mesh.conversion.mask() wrapper function uses the newer python-based mask creation and only creates region masks, not transect masks.

@xylar xylar requested a review from vanroekel January 4, 2024 10:32
@xylar xylar self-assigned this Jan 4, 2024
@xylar
Copy link
Collaborator Author
xylar commented Jan 4, 2024

@vanroekel, please confirm that the updated documentation now works for you, following up on our conversation on Slack.

Copy link
Contributor
@vanroekel vanroekel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is consistent with the workflow I used to alter coastlines. Thanks for the quick update @xylar!

@xylar xylar merged commit 0634d97 into MPAS-Dev:master Jan 4, 2024
@xylar xylar deleted the update-coastline-alteration-docs branch January 4, 2024 17:11
@xylar
Copy link
Collaborator Author
xylar commented Jan 4, 2024

Thanks @vanroekel!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0