8000 Remove pmc dependency by navidmahmoudian · Pull Request #7 · MIT-SPARK/ROBIN · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove pmc dependency #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Remove pmc dependency #7

wants to merge 5 commits into from

Conversation

navidmahmoudian
Copy link

Introduce WITH_PMC CMake option to conditionally disable the PMC dependency, aligning with the MIT license. This change also resolves compilation issues on Windows with the MSVC compiler.

@navidmahmoudian navidmahmoudian mentioned this pull request May 12, 2025
Open
@navidmahmoudian
Copy link
Author

For more details, please see the response this issue.

@jingnanshi
Copy link
Member

Thanks for the PR. Since PMC is downloaded during build so no need to remove the dependency for licensing issue. In other words, because we don't include PMC source code with our repo, GPL license is not an issue. I'll look at the MSVC compilation issue when I have time.

@navidmahmoudian
Copy link
Author

Hello,

Thanks for your reply. I've addressed the MSVC issue in my PR by using std::atomic within pkc.cpp. The unit tests are currently passing. Would you mind taking a look when you have a moment, or perhaps trying to compile and run the tests on your end?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@navidmahmoudian @jingnanshi
0