concepts_postgres: updates (on top of mimiciv_v2.2_updates)
#1468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `search_path` part of `postgres-make-concepts.sql` was not added in `convert_bigquery_to_postgres.sh` yet. Add it on order to be able to re-run the conversion. Follow-up for 547f623
Re-run `convert_bigquery_to_postgres.sh` to update the Postgres concepts. In particular, remove an old include.. ``` \i measurement/differential_detailed.sql ``` ..that leads to the following error: ``` psql:postgres-make-concepts.sql:35: error: measurement/differential_detailed.sql: No such file or directory ```
1 task
|
Ah thanks for pulling in those updates, though it's interesting your run sorts |
|
Nevermind about the above, I forgot I already made them both rely on the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few changes on top of https://github.com/MIT-LCP/mimic-code/tree/mimiciv_v2.2_updates to update the Postgres concepts code. Please see the individual commit messages for details.