10000 new: [Bookmarks] allow site admins to create global bookmarks by goodlandsecurity · Pull Request #10377 · MISP/MISP · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

new: [Bookmarks] allow site admins to create global bookmarks #10377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

goodlandsecurity
Copy link
Contributor

What does it do?

This PR allows site admins to create global bookmarks (exposed to all users on an instance). This feature will be especially beneficial in community instances, allowing site admins to share bookmarks for search queries to view intel specific to an industry, threat actor, threat type, etc. while not requiring the end user to need to create their own.

Questions

  • Does it require a DB change?
  • Are you using it in production?
  • Does it require a change in the API (PyMISP for example)?

@adulau adulau requested a review from iglocska June 6, 2025 04:30
@iglocska
Copy link
Member

That would indeed be handy, but it is a bit dangerous as it is - could you modify it so that only site admins can add global bookmarks? Also, could you add a new db upgrade script to accomodate for the new field? Have a look at for example update 138, just search AppModel.php for 138 to see what was added to make it work.

Thanks for the PR and sorry that it took this long to respond.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0