This repository was archived by the owner on Sep 8, 2024. It is now read-only.
Fix replacement of existing Skill loader in queue #2899
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Voight Kampff Integration Test Succeeded (Results) |
forslund
approved these changes
May 7, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a typo in the Skill loader queue methods. It was evaluating rather than assigning the output of a list comprehension.
This would prevent the existing Skill loader from being removed from the queue but still append the new one.
Thanks to @JarbasAI for spotting this!
How to test
Extended existing unit tests to check for this scenario.
Contributor license agreement signed?