8000 Move TTS cache curation to TextToSpeechCache by forslund · Pull Request #2869 · MycroftAI/mycroft-core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Sep 8, 2024. It is now read-only.

Move TTS cache curation to TextToSpeechCache #2869

Merged
merged 2 commits into from
Mar 19, 2021
Merged

Move TTS cache curation to TextToSpeechCache #2869

merged 2 commits into from
Mar 19, 2021

Conversation

forslund
Copy link
Collaborator

Description

Feels like this should also fit nicely into the new class.

Contributor license agreement signed?

CLA [ yes ]

@forslund forslund requested a review from chrisveilleux March 18, 2021 22:09
@devops-mycroft devops-mycroft added the CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) label Mar 18, 2021
@devops-mycroft
Copy link

Voight Kampff Integration Test Succeeded (Results)

chrisveilleux
chrisveilleux approved these changes Mar 18, 2021
View reviewed changes
Copy link
Member
@chrisveilleux chrisveilleux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You caught a caching function I missed! Thanks. This looks good.

@krisgesling krisgesling merged commit 7d3cb2d into MycroftAI:dev Mar 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chrisveilleux chrisveilleux chrisveilleux approved these changes

Assignees
No one assigned
Labels
CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@forslund @devops-mycroft @chrisveilleux @krisgesling
0