This repository was archived by the owner on Sep 8, 2024. It is now read-only.
remove hardcoded timeouts - now in mycroft.conf #2668
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forslund
reviewed
Aug 18, 2020
mycroft/client/speech/mic.py
Outdated
| @@ -374,14 +364,12 @@ def __init__(self, wake_word_recognizer, watchdog=None): | |||
|
|
|||
| # The maximum seconds a phrase can be recorded, | |||
| # provided there is noise the entire time | |||
| self.recording_timeout = listener_config.get('recording_timeout', | |||
| self.RECORDING_TIMEOUT) | |||
| self.recording_timeout = listener_config.get('recording_timeout') | |||
There was a problem hiding this comment.
Maybe use brackets here to generate a lookup error if it's missing from config. This will default to None and cause issues when used.
There was a problem hiding this comment.
should i just include the previous hardcoded values as a sane backup default?
There was a problem hiding this comment.
This is a case where I'm not quite sure what I think, if these are completely missing the default config is either missing or messed up. Sane defaults are generally a good thing though and the user would get a warning that the config failed to load if that were the case. So you're probably right.
|
Voight Kampff Integration Test Succeeded (Results) |
894da67 to
d4d7d09
Compare
|
Voight Kampff Integration Test Succeeded (Results) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes hardcoded recording timeout values that were moved to the default
mycroft.conf.They were left for backwards compatibility. Removing in preparation for 20.08
How to test
listener.recording_timeoutparameter to 2.0 and ensure no utterance can exceed 2 seconds.listener.recording_timeout_with_silenceparameter to 10.0 and listener will record a full 10 seconds of silence.Contributor license agreement signed?