Refactor intent service #2599
Refactor intent service #2599
Conversation
6c6a61c to
acf750b
Compare
|
Voight Kampff Integration Test Failed (Results) |
1 similar comment
|
Voight Kampff Integration Test Failed (Results) |
acf750b to
e4e1415
Compare
|
Voight Kampff Integration Test Failed (Results) |
|
Voight Kampff Integration Test Failed (Results) |
|
Voight Kampff Integration Test Succeeded (Results) |
e4e1415 to
6e2c9f8
Compare
|
Voight Kampff Integration Test Failed (Results) |
|
Voight Kampff Integration Test Succeeded (Results) |
|
Voight Kampff Integration Test Failed (Results) |
6e2c9f8 to
1a91a32
Compare
|
Voight Kampff Integration Test Failed (Results) |
1a91a32 to
b593fb3
Compare
|
Voight Kampff Integration Test Failed (Results) |
1 similar comment
|
Voight Kampff Integration Test Failed (Results) |
|
Good catches all over. Will update the PR during the day |
b593fb3 to
ecaa3ae
Compare
|
Voight Kampff Integration Test Succeeded (Results) |
a4f4d18 to
d84956b
Compare
|
Voight Kampff Integration Test Succeeded (Results) |
|
Valid point, will update |
|
Question which rule-set are we aming to conform to? |
If no range is provided it defaults to 0-100 to be backwards compatible
Simplify the handle_utterance into a list of intent matching functions run in order until a match is found. The resolution order is - Converse - Padatious High Confidence - Adapt - Fallback High priority - Padatious Medium Confidence - Fallback Medium priority - Padatious Last ditch effore - Fallback Low priority This collects the many parts of where intent is handled into a single location handling the entire flow. The idea is that, in the end, all the skill calling should be done from this method. The main intent parsers does this but the converse and fallback still calls directly.
This issue was properly fixed in Adapt 0.3.5.
5d3a296 to
336dd70
Compare
- Move setting original utterance to the respective intent service - Remove botch limiting the intent service to a single STT hypothesis
- imports - All docstring - AdaptService method warnings
- Add missing docstrings - fix short variable names - restructure return code
336dd70 to
8089411
Compare
|
Voight Kampff Integration Test Failed (Results) |
|
Voight Kampff Integration Test Succeeded (Results) |
|
Voight Kampff Integration Test Succeeded (Results) |
54380d1 to
8a8caa5
Compare
|
Voight Kampff Integration Test Succeeded (Results) |
|
Thanks again for this huge clean up Ake, it's fantastic work! I'm going to leave the commits unsquashed as they each represent a significant change and are already well structured. |
Description
The intent handling has been spread out over a bunch of files and this sort of collects it back into a single location makes the entire flow viewable from a single handler for the old
recognizer_loop:utterancemessage.The resolution order is the same as before only expressed as a single list instead of a series of checks and fallbacks interlaced.
This collects the many parts of where intent is handled into a single
location handling the entire flow.
The idea is that, in the end, all the skill calling should be done from
this method. The main intent parsers does this but the converse and
fallback still calls directly.
Future work: Converse and fallback still triggers handlers directly.
How to test
Best way to test this is to make sure the voight kampff tests are still passing.
Contributor license agreement signed?
CLA [ Yes ]