dev_setup.sh: add support for Alpine Linux #2584
Conversation
|
Voight Kampff Integration Test Succeeded (Results) |
|
I'm getting a bunch of errors when running this in my alpine VM, logs here: http://termbin.com/ygs2 wonder if the The error collecting packages I'm not sure about |
|
Am I missing something in my alpine setup to get those packages? |
|
Ah my system has the GNU coreutils installed, which I didn't think about. Seems to be a dep of the script. That makes it a tad annoying to fix, as we'd need to make the whole script POSIX compliant. If |
|
Voight Kampff Integration Test Succeeded (Results) |
|
As for the packages it couldn't find, make sure you have the |
|
I'll see if I can figure out what actually needs the -P flag... |
|
Voight Kampff Integration Test Succeeded (Results) |
|
Seems like the following is a working replacement for the os_is_like method: function os_is_like() {
grep "^ID_LIKE=" /etc/os-release | awk -F'=' '/^ID_LIKE/ {print $2}' | sed 's/\"//g' | grep -q "\\b$1\\b"
}I needed to add |
|
Thanks for that find! I updated the PR with your grep and package changes. |
|
Voight Kampff Integration Test Failed (Results) |
|
Voight Kampff Integration Test Succeeded (Results) |
|
Looks good, merging. |
Description
This adds Alpine Linux support to the
dev_setup.shscript.Also make the Arch check use
is_os, as it already thought my Alpine installation was Arch Linux just because I had pacman installed. Distros often have package managers for other distros available in their repositories for bootstrapping, so you can't guess an OS just by their package managers installed.How to test
Run the script on Alpine Linux and see if everything builds and runs correctly
Contributor license agreement signed?
CLA [x]