This repository was archived by the owner on Sep 8, 2024. It is now read-only.
Update skill stop sequence #2529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The upload queue will now check if it's stopped while consuming the queue, allowing quicker shutdown if triggered while in the middle of uploading settingsmeta.
"stop-mycroft.sh all" stopped the messagebus before the services were shutdown, causing disconnected errors for the processes and making some of the shutdown code take longer.
The 5 second timeout made the playback control take quite some time to shutdown if the audio process isn't running.
chrisveilleux
approved these changes
Apr 7, 2020
This was referenced Apr 17, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Contributor license agreement signed?
CLA [ Yes ]