8000 chore: Upgrade dependencies to the latest and greatest by frankverhoeven · Pull Request #58 · MyOnlineStore/common-domain · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: Upgrade dependencies to the latest and greatest #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 8, 2022
Merged

chore: Upgrade dependencies to the latest and greatest #58

merged 1 commit into from
Aug 8, 2022

Conversation

frankverhoeven
Copy link
Contributor
@frankverhoeven frankverhoeven commented Jul 20, 2022 •
edited
Loading

To improve compatibility with PHP 8.1

Notable changes:

  • Domain validation appears to be changed slightly, allowing more formats
  • Domain ruleset is no longer fetched online, but is instead embedded in the domainName VO, meaning we may have to manually update it from time to time
  • Url no longer extends the League Http class, because it has been made final. All constructors and methods were copied to our VO to ease the transition. Perhaps we are better of dropping our own Url VO all together and use the league version instead.

@frankverhoeven frankverhoeven added the enhancement New feature or request label Jul 20, 2022
@frankverhoeven
chore: Upgrade dependencies to the latest and greatest
02a3ebd 
To improve compatibility with PHP 8.2
@fred-jan fred-jan merged commit f5da7f5 into 2.x-dev Aug 8, 2022
@fred-jan fred-jan deleted the 2.x-upgrade-packages branch August 8, 2022 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fred-jan fred-jan fred-jan approved these changes

@gertjuhh gertjuhh Awaiting requested review from gertjuhh

@jkiesebrink jkiesebrink Awaiting requested review from jkiesebrink

@Peter-Weijenburg Peter-Weijenburg Awaiting requested review from Peter-Weijenburg

@bramvandooren bramvandooren Awaiting requested review from bramvandooren

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frankverhoeven @fred-jan
0