8000 chore: Updated valinor from 0.5 to 0.6 by fred-jan · Pull Request #55 · MyOnlineStore/common-domain · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: Updated valinor from 0.5 to 0.6 #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 21, 2022
Merged

chore: Updated valinor from 0.5 to 0.6 #55

merged 2 commits into from
Apr 21, 2022

Conversation

fred-jan
Copy link
Contributor
@fred-jan fred-jan commented Apr 13, 2022 •
edited
Loading

Should be tagged as 2.5.3

This updated is required to get the api-tools package installed in the monolith.

@fred-jan fred-jan added the sprint Sprint Task label Apr 13, 2022
@frankverhoeven
Copy link
Contributor

Did you test this branch in payment?

8000

@fred-jan
Copy link
Contributor Author

Did you test this branch in payment?

Nope only in the monolith

@frankverhoeven
Copy link
Contributor
frankverhoeven commented Apr 21, 2022 •
edited
Loading

I think we should bump valinor to ^0.7: GHSA-xhr8-mpwq-2rr2

@frankverhoeven
Copy link
Contributor

It does break payment due to the breaking changes from Valinor.

@frankverhoeven
Copy link
Contributor
frankverhoeven commented Apr 21, 2022 •
edited
Loading

I would move valinor to require-dev. It is only used for the annotations, the code in this repo does not depend on it.
Then the package that consumes common-domain can define the valinor version to use.

@fred-jan
Copy link
Contributor Author

Then the package that consumes common-domain can define the valinor version to use.

The package that consumes it will still be constrained to a specific version of Valinor that supports annotations though. Putting it in require-dev might lead to situations where the consuming package updates Valinor to a new version that dropped annotation support for example, leading to all kinds of adverse effects that might not be covered by functional tests.

@frankverhoeven frankverhoeven merged commit 5f45d9b into 2.x-dev Apr 21, 2022
@frankverhoeven frankverhoeven deleted the 2.x-valinor-update branch April 21, 2022 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankverhoeven frankverhoeven frankverhoeven approved these changes

@LittlestFluffy LittlestFluffy Awaiting requested review from LittlestFluffy

@Peter-Weijenburg Peter-Weijenburg Awaiting requested review from Peter-Weijenburg

Assignees
No one assigned
Labels
sprint Sprint Task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fred-jan @frankverhoeven
0