Infrastructure: investigate #7740 #7741
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#### Brief overview of PR changes/additions Adds a couple of debug output lines to report the Mudlet application's idea of what it's "current working directory" is immediately prior to running the `TLuaInterpreter::loadGlobal()` method. #### Motivation for adding to Mudlet This is designed to aide in the diagnosis of the issue Mudlet#7740 which only seems to manifest in Release and PTB builds of Mudlet on Windows. #### Other info (issues closed, discussion etc) I think this will be needed to be merging into the development branch - so as to incorporate it into a PTB for testing. It is only a couple of lines and should not interfere with the operation of the code as it only introduces an extra line of text into the debug output each time a profile is (re)loaded. I suspect, but need this to confirm it, that, unlikely as it should be, a particular package seems to be capable of modifying the execution environment of the Mudlet application from a profile's Lua interpreter. This shouldn't be possible, but I am just following up on the pronouncement of the fictional detective *Sherlock Homes*: > "You will not apply my precept," he said, shaking his head. "How often have I said to you that when you have eliminated the impossible, whatever remains, however improbable, must be the truth?" > -- Authur Conan Doyle, *The Sign of the Four*, ch. 6 (1890) Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
|
|
💡 Actually, since I haven't up dated my MSYS2+Mingw-w64 installation on my Windows Laptop recently I should be able to cherry-pick this PR onto the 4.19.1 code and build a |
|
is this still required? |
|
I think we still have the problem although the person who brought it up changed their scripts to be a bit more cautious about using the luafilesystem |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief overview of PR changes/additions
Adds a couple of debug output lines to report the Mudlet application's idea of what it's "current working directory" is immediately prior to running the
TLuaInterpreter::loadGlobal()method.Motivation for adding to Mudlet
This is designed to aide in the diagnosis of the issue #7740 which only seems to manifest in Release and PTB builds of Mudlet on Windows.
Other info (issues closed, discussion etc)
I think this will be needed to be merging into the development branch - so as to incorporate it into a PTB for testing. It is only a couple of lines and should not interfere with the operation of the code as it only introduces an extra line of text into the debug output each time a profile is (re)loaded.
I suspect, but need this to confirm it, that, unlikely as it should be, a particular package seems to be capable of modifying the execution environment of the Mudlet application from a profile's Lua interpreter. This shouldn't be possible, but I am just following up on the pronouncement of the fictional detective Sherlock Homes: