Debian Bug report logs - #801760
[checks/manpages] manpage-named-after-build-path won't trigger for packages built in sbuild

Display info messages

Message #3 received at submit@bugs.debian.org (full text, mbox, reply):

From: Jakub Wilk <jwilk@debian.org>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: [checks/manpages] manpage-named-after-build-path won't trigger for packages built in sbuild

Date: Wed, 14 Oct 2015 12:30:27 +0200

Package: lintian
Version: 2.5.38

This code was meant to catch bugs like #713883:

       if ($file =~ m/_build_buildd/ or $file =~ /_tmp_buildd/) {
           tag 'manpage-named-after-build-path', $file;
       }

But sbuild builds stuff in /build/$PACKAGE-$RANDOMSTRING, so this regexp 
wouldn't match anything, unless the source package name starts with 
"buildd".

(sbuild in buildd mode used to use /build/buildd-$PACKAGE-$RANDOMSTRING, 
but AFAICS it now uses "buildd-"less paths.)

-- 
Jakub Wilk

Message #8 received at 801760@bugs.debian.org (full text, mbox, reply):

From: Mattia Rizzolo <mattia@mapreri.org>

To: 801760@bugs.debian.org

Subject: Re: Bug#801760: [checks/manpages] manpage-named-after-build-path won't trigger for packages built in sbuild

Date: Wed, 14 Oct 2015 17:28:03 +0000

[Message part 1 (text/plain, inline)]

On Wed, Oct 14, 2015 at 12:30:27PM +0200, Jakub Wilk wrote:
> Package: lintian
> Version: 2.5.38
> 
> This code was meant to catch bugs like #713883:
> 
>        if ($file =~ m/_build_buildd/ or $file =~ /_tmp_buildd/) {
>            tag 'manpage-named-after-build-path', $file;
>        }
> 
> But sbuild builds stuff in /build/$PACKAGE-$RANDOMSTRING, so this regexp
> wouldn't match anything, unless the source package name starts with
> "buildd".

Also, pbuilder now easily allow changing the build path, and defaults
to /build/ (with inside the .dsc, .orig, etc and a $pkg-$ver directory,
as created by dpkg).

I wonder if just using
    $file =~ m/_build_/
instaead of
    $file =~ m/_build_buildd/
is sane enough.

-- 
regards,
                        Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540      .''`.
more about me:  http://mapreri.org                              : :'  :
Launchpad user: https://launchpad.net/~mapreri                  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 801760@bugs.debian.org (full text, mbox, reply):

From: Jakub Wilk <jwilk@debian.org>

To: 801760@bugs.debian.org

Subject: Re: Bug#801760: [checks/manpages] manpage-named-after-build-path won't trigger for packages built in sbuild

Date: Wed, 14 Oct 2015 23:53:56 +0200

* Mattia Rizzolo <mattia@mapreri.org>, 2015-10-14, 17:28:
>I wonder if just using
>    $file =~ m/_build_/
>instaead of
>    $file =~ m/_build_buildd/
>is sane enough.

There are legitimate manpages that have "_build_" in their name, for 
example:
/usr/share/man/man1/slonik_build_env.1.gz (in slony1-2-bin)

This should be okay:

$file =~ m{/_build_}

-- 
Jakub Wilk

Message #18 received at 801760-close@bugs.debian.org (full text, mbox, reply):

From: Niels Thykier <niels@thykier.net>

To: 801760-close@bugs.debian.org

Subject: Bug#801760: fixed in lintian 2.5.50

Date: Mon, 26 Dec 2016 16:33:30 +0000

Source: lintian
Source-Version: 2.5.50

We believe that the bug you reported is fixed in the latest version of
lintian, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 801760@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Niels Thykier <niels@thykier.net> (supplier of updated lintian package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Mon, 26 Dec 2016 16:07:20 +0000
Source: lintian
Binary: lintian
Architecture: source
Version: 2.5.50
Distribution: unstable
Urgency: medium
Maintainer: Debian Lintian Maintainers <lintian-maint@debian.org>
Changed-By: Niels Thykier <niels@thykier.net>
Description:
 lintian    - Debian package checker
Closes: 685029 740161 743599 801760 818962 829744 834867 839822 842781 843406 843595 844903 845201 847318 847535 847558
Changes:
 lintian (2.5.50) unstable; urgency=medium
 .
   * Summary of tag changes:
     + Added:
       - invalid-value-in-built-using-field
       - license-problem-convert-utf-code
       - new-package-should-not-package-python2-module
       - php-script-but-no-php-cli-dep
       - php-script-with-unusual-interpreter
     + Removed:
       - php-script-but-no-phpX-cli-dep
 .
   * checks/binaries.{desc,pm}:
     + [NT] Handle RUNPATH like we handle RPATH.  (Closes: #844903)
     + [NT] Update hardening-no-pie description to reflect that
       PIE is on by default in Debian.
   * checks/cruft.desc:
     + [BR] Detect utf convert non free code.
       (Closes: #843595)
   * checks/deb-format.pm:
     + [NT] Permit uncompressed {control,data}.tar members plus xz
       compressed control.tar files in deb files.  Thanks to
       Guillem Jover for the report.  (Closes: #834867)
   * checks/debhelper.pm:
     + [BR] Apply patch from Yann Soubeyrand :
       "Allow debhelper "--with" addons to be quoted".
       (Closes: #839822)
   * checks/files.{desc,pm}:
     + [NT] Check for invalid clauses in "Built-Using" fields.  Thanks to
       Andrey Rahmatullin for the suggestion.  (Closes: #847558)
     + [NT] Apply patch from Josh Triplett to add new sections to
       descriptions.
   * checks/files.desc:
     + [NT] Document that we no longer accept "virtual packages"
       for deliberately empty packages.  If your package receives
       an "empty-binary-package" tag, please replace the use of
       "virtual package".
   * checks/{files,scripts}.pm:
     + [NT] Apply patch from Josh Triplett to exclude files under
       /usr/share/cargo/registry/ from a few checks as that directory
       contains unmodified upstream sources.  (Closes: #845201)
   * checks/manpages.pm:
     + [JW, NT] Fix false negative manpage-named-after-build-path
       for packages built by sbuild.  (Closes: #801760)
   * checks/scripts.{desc,pm}:
     + [JW, NT] Apply patch from Antonio Ospite that updates the
       test for php scripts without a php-cli dependency.  Thanks
       to Ondřej Surý for the report and Mathieu Parent for the
       initial patch.  (Closes: #818962)
     + [CL, NT] Warn about new source packages providing a python2
       package as EOL for python2 is expected in 2020, which is
       before buster's expected EOL.  (Closes: #829744)
 .
   * collection/objdump-info.desc:
     + [NT] Bump version due to RUNPATH collection.
 .
   * commands/lintian:
     + [NT] Deprecate --fail-on-warnings, which will be removed in
       Debian/buster.
 .
   * data/binaries/embedded-libs:
     + [BR] Allow openssl1.0 as source package.  (Closes: #843406).
   * data/debhelper/dh_commands-manual:
     + [NT] Apply patch from Piotr Ożarowski that ensure that
       consumers of dh_python2 Build-Depends on dh-python.
       (Closes: #740161)
   * data/fields/archive-sections:
     + [NT] Apply patch from Josh Triplett to add javascript and
       rust sections.  (Closes: #847535)
   * data/files/privacy-breaker-websites:
     + [BR] Detect more logos.
   * data/scripts/interpreters:
     + [NT] Apply patch from Antonio Ospite to correct a false
       positive warning for python scripts using python2 in the
       shebang line.  Thanks to Per Andersson for the report and
       Luca Boccassi for the initial patch for solving this.
       (Closes: #743599)
   * data/spelling/corrections:
     + [PW] Add more corrections.
   * data/spelling/corrections-case:
     + [EG] Correct spelling of Lua (Closes: #842781)
 .
   * helpers/coll/objdump-info-helper:
     + [NT] Extract RUNPATH from binaries as well.
 .
   * lib/Lintian/Collect/Binary.pm:
     + [NT] Expose RUNPATH when set in the binary.
     + [NT] Remove "virtual package" from the list of phrases
       marking a package as a meta-package.  Thanks to Stuart
       Prescott for the report.  (Closes: #685029)
 .
   * profiles/kali/main.profile:
     + [NT] Add a profile for Kali Linux.  Thanks to Raphaël
       Hertzog for the report.  (Closes: #847318)
 .
   * vendors/kali/main/data/changes-file/known-dists:
     + [NT] Add data file for Kali Linux.
Checksums-Sha1:
 9e69721de46eb0403e965146fa27f811a51c08ab 2813 lintian_2.5.50.dsc
 ac88ebc4a38039e6e05371549763316c425d645e 1234588 lintian_2.5.50.tar.xz
Checksums-Sha256:
 afcd908621b0f54cba88e5dd91582a15846eba6c92e93d49743e8a8c7cd203e9 2813 lintian_2.5.50.dsc
 3d0888655ae4b875f514cb3c18b0e17af51c1086a8fcaf8316ddd677f8668224 1234588 lintian_2.5.50.tar.xz
Files:
 fe16926a354d4744346ff35d12ca7f0d 2813 devel optional lintian_2.5.50.dsc
 a7864b677db4df8360a4b2f50c42314f 1234588 devel optional lintian_2.5.50.tar.xz

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEsxMaRR2/33ygW0GXBUu7n32AZEIFAlhhQ+QACgkQBUu7n32A
ZELTdw//b+WBlkGT/bD0Gfzm6ZLH9F42yEKKstzyMlEJugMWH61ibXKTisHHYwxP
rIfFlOR0n754LfH0Y+jPvPHFLgakVSxGdXnIFmkFSptHA/RjOvNm3zUgNVKShKtV
X58V9tHBYAZTmMX6Cv6VMkTW4tvYe/gJL1ucDiPOxe6JCsFwzsQSDyDtlMNLdTTB
aFZ0NjXcnaVnIiniapWIcfXq0TDedaJ5R2YzY3OpSPTDIVIfLQzVIzNnLHakoRyh
aBmpK/xLBjBKZpXqZSrqky4beg/myD2DqaV1+jH5oku4g7A8okIRmwimDdZjSlqe
ilVpR4+YyZC+de/c/PETarh6k0EGT71mrBJUVq9DmJqzIvlfHrEbZVaHA0d4aXAh
WHQhQ2+UU7VuRjsiirAyA0Bz5+mIDLzgrM4pZRNW/+R58YfUWLxvoCYXLIIdj/yv
gKel0u8veiob8aKcEDanin2TMl+SKegxqwRd418PjAcZUQldYDL1oOQV+JEd/mCb
q9W47vJD51h5/SvRLEdBQ4ZKhqNV2+U7KIMTAcg6thsCO8iJT+eZrb1HL6lqPL76
LbCuSTVQ5qlG0l/9zEWJrrXzFvTigUadxAt5FNjAYIb8yBdE4WjX2D9SNYbrs05g
Rtstmpxv+b6BpxzSm8gvpvm/kvsBMxfPNtGLr8AcdCf8TYKMz98=
=ertm
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.