Debian Bug report logs - #1087906
python-formencode: autopkgtest does not test the packaged version

Reply or subscribe to this bug.

Display info messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Stuart Prescott <stuart@debian.org>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: python-formencode: autopkgtest does not test the packaged version

Date: Wed, 20 Nov 2024 14:38:56 +1100

Source: python-formencode
Version: 2.1.0-3
Severity: serious
Justification: Policy 5.6.30 autopkgtests to test packages
X-Debbugs-Cc: stuart@debian.org

Dear Maintainer,

The autopkgtest for python-formencode fails trying to import cgi,
despite this being protected in the code:

```
-import cgi
+try:
+    import cgi
+except ImportError:  # Python >= 3.13
+    cgi = None

```

```
179s   File "/tmp/tmp.ragNVqzDlz/testve/lib/python3.13/site-packages/formencode/validators.py", line 8, in <module>
179s     import cgi
179s ModuleNotFoundError: No module named 'cgi'
```

The reason is that the testfe-setuptools test is downloading the wheel
for python-formencode from pypi, rather than testing the packaged code.

```
175s Processing ./mypkg
175s   Installing build dependencies: started
177s   Installing build dependencies: finished with status 'done'
177s   Getting requirements to build wheel: started
178s   Getting requirements to build wheel: finished with status 'done'
178s   Preparing metadata (pyproject.toml): started
178s   Preparing metadata (pyproject.toml): finished with status 'done'
178s Collecting FormEncode>=2.0.0 (from testlib==0.0.1)
178s   Downloading FormEncode-2.1.0-py3-none-any.whl.metadata (2.6 kB)
178s Downloading FormEncode-2.1.0-py3-none-any.whl (179 kB)
178s Building wheels for collected packages: testlib
178s   Building wheel for testlib (pyproject.toml): started
178s   Building wheel for testlib (pyproject.toml): finished with status 'done'
178s   Created wheel for testlib: filename=testlib-0.0.1-py3-none-any.whl size=2160 sha256=1aa083f239c6619c0268041352d9be133a0199edd4f62452662ce2bec24c629b
178s   Stored in directory: /tmp/pip-ephem-wheel-cache-2w10qcp7/wheels/a9/53/73/fc687042e85b74223bbd3af9c9f7c0579e392aa81868699a26
178s Successfully built testlib
178s Installing collected packages: FormEncode, testlib
178s Successfully installed FormEncode-2.1.0 testlib-0.0.1
```

Having downloaded FormEncode from pypi, the Debian patches are not in
place and the package fails.

Perhaps the call to virtualenv needs `--system-site-packages`?

regards
Stuart

Message #8 received at 1087906-submitter@bugs.debian.org (full text, mbox, reply):

From: Colin Watson <cjwatson@debian.org>

To: 1087906-submitter@bugs.debian.org

Subject: Bug#1087906 marked as pending in python-formencode

Date: Wed, 20 Nov 2024 09:17:46 +0000

Control: tag -1 pending

Hello,

Bug #1087906 in python-formencode reported by you has been fixed in the
Git repository and is awaiting an upload. You can see the commit
message below and you can check the diff of the fix at:

https://salsa.debian.org/python-team/packages/python-formencode/-/commit/2e00d2d8fabe7de199615b98dfbf4730a157bded

------------------------------------------------------------------------
debian/tests/testfe-setuptools: Use `virtualenv --system-site-packages`

Closes: #1087906
------------------------------------------------------------------------

(this message was generated automatically)
-- 
Greetings

https://bugs.debian.org/1087906

Message #15 received at 1087906-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>

To: 1087906-close@bugs.debian.org

Subject: Bug#1087906: fixed in python-formencode 2.1.0-4

Date: Wed, 20 Nov 2024 09:36:10 +0000

[Message part 1 (text/plain, inline)]

Source: python-formencode
Source-Version: 2.1.0-4
Done: Colin Watson <cjwatson@debian.org>

We believe that the bug you reported is fixed in the latest version of
python-formencode, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1087906@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Colin Watson <cjwatson@debian.org> (supplier of updated python-formencode package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Wed, 20 Nov 2024 10:16:23 +0100
Source: python-formencode
Architecture: source
Version: 2.1.0-4
Distribution: unstable
Urgency: medium
Maintainer: Fabio Tranchitella <kobold@debian.org>
Changed-By: Colin Watson <cjwatson@debian.org>
Closes: 1087906
Changes:
 python-formencode (2.1.0-4) unstable; urgency=medium
 .
   * Team upload.
   * debian/tests/testfe-setuptools: Use `virtualenv --system-site-packages`
     (closes: #1087906).
Checksums-Sha1:
 f4f8e408576ab4802ee39243b912b1d5fdb31ff0 2513 python-formencode_2.1.0-4.dsc
 ca5407b04196e1c54001f69990993f5f4171a71b 10224 python-formencode_2.1.0-4.debian.tar.xz
Checksums-Sha256:
 a82202e4e40fdfe2b7da2bf644fcbd40df3571a0ea1a83f6df06d685bc4d6919 2513 python-formencode_2.1.0-4.dsc
 ceab107d5402340dcf35777d963515c33eb1850365d433c9fd70348cd4510c07 10224 python-formencode_2.1.0-4.debian.tar.xz
Files:
 7aee995deac2f5ee0bc3fb32269405b5 2513 python optional python-formencode_2.1.0-4.dsc
 684ba204fb0272f3d0b5267caacf9d71 10224 python optional python-formencode_2.1.0-4.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEErApP8SYRtvzPAcEROTWH2X2GUAsFAmc9qSUACgkQOTWH2X2G
UAveaRAAlLscLLsMgDciZOkFh81obXB/DbKYHf0KYATJ+uwvyAJC7ff4koq3bV4P
MMGKPO/hbpgN9fUQ4sc/MhPnRUis//a1My5yiBQQ6RJ/wFRrKCRKbWy7h1C0awek
9v0P2z331eXZvuCsZZMzkfRzdPykJnkR600vkOuYqhO6bJ0TNBWKEc8NrTa0SMjH
lBAFBFoLaBAifbM7938AcNty1pYASNgt/V3tx4ZjCfKSMYBS/+INm9W5OW0fZ4w/
/NDM5KEDtIWnaEbqvUriJv/0IK+nYMCvfslNfChrzkXWx21TppXW9hc+sPtERAly
MtG3XrCz+C8qJWZlcAtBtQCxOkT+bkd65HZ8ZeYtFn0dNclAoYe3GEXvDethnPfn
i+nNFXNG0G7mE0aJNzL4WY0/B8zJe/pxVylxYGwRyLgP/IoRnZ7HmrdYHFdfZx/r
N+FS9OqpKPDcgT7Mf44FoAVEz4AS7+UhH9etjzNhl7hEBX1F1SQgiyP3MUbOl1i9
aNyvIn7K/65KZrd/R3E1ckYEb8DjVqfWEwwZHyf6Dlz9nYDGG5Wn52dMNKWMKqw8
FuMlVNct5/55QNcGoHL8lJXFm4Nv3LNTunl50ncO51uxIZN8Flun5uhQnsAndKZA
PFlYbmLoc7/eu3V/591nsbGcfPyogXCUWtzxIjTKS9wBs32DO3M=
=OVip
-----END PGP SIGNATURE-----

[Message part 2 (application/pgp-signature, inline)]

Send a report that this bug log contains spam.