Use a per-documentLoader resolved context cache.
#552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A bit more info for this issue:
About this initial fix:
For future work, the entire caching setup should be revisited. Apps should have more control over cache use, size, and duration. There are many ways this could be designed. |
dlongley
approved these changes
May 31, 2024
Fixes an issue where multiple document loaders are used which each have different values for static contexts. A WeakMap is used for caches and is cleaned up using WeakMap semantics based on the lifetime of the documentLoader keys.
67f38b9 to
0664018
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where multiple document loaders are used which each have different values for static contexts.
A WeakMap is used for caches and is cleaned up using WeakMap semantics based on the lifetime of the documentLoader keys.