8000 Expand `ActionError` codes to include all IANA HTTP error codes by romanstetsyk · Pull Request #13769 · withastro/astro · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Expand ActionError codes to include all IANA HTTP error codes #13769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 21, 2025

Conversation

romanstetsyk
Copy link
Contributor

Changes

Expand ActionError codes to include all IANA-registered HTTP error codes. Related discussion.

Possible issues that can affect existing projects:

  • 405 TIMEOUT replaced by 405 METHOD_NOT_ALLOWED, which is the accurate name for the 405 code. REQUEST_TIMEOUT is 408.
  • 413 PAYLOAD_TOO_LARGE replaced by 413 CONTENT_TOO_LARGE.
  • 499 CLIENT_CLOSED_REQUEST removed as non-standard.

Testing

No tests written. Tested by linking the local astro fork using pnpm link.

Docs

The expanded list of error codes doesn’t affect existing documented behavior.

Copy link
changeset-bot bot commented May 8, 2025

🦋 Changeset detected

Latest commit: 28f465d

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label May 8, 2025
Copy link
codspeed-hq bot commented May 8, 2025

CodSpeed Performance Report

Merging #13769 will not alter performance

Comparing romanstetsyk:iana-action-error-codes (28f465d) with main (85b19d8)

Summary

✅ 6 untouched benchmarks

Copy link
Contributor
@ascorbic ascorbic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ascorbic ascorbic merged commit e9fc456 into withastro:main May 21, 2025
27 of 28 checks passed
@astrobot-houston astrobot-houston mentioned this pull request May 21, 2025
hkbertoson pushed a commit to hkbertoson/astro that referenced this pull request Jul 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
0