8000 fix: socialLinks theme config type should be optional by dream2023 · Pull Request #1694 · umijs/dumi · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: socialLinks theme config type should be optional #1694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 27, 2023
Merged

fix: socialLinks theme config type should be optional #1694

merged 1 commit into from
May 27, 2023

Conversation

dream2023
Copy link
Contributor

🤔 这个变动的性质是？/ What is the nature of this change?

  • 新特性提交 / New feature
  • bug 修复 / Fix bug
  • 样式优化 / Style optimization
  • 代码风格优化 / Code style optimization
  • 性能优化 / Performance optimization
  • 构建优化 / Build optimization
  • 网站、文档、Demo 改进 / Website, documentation, demo improvements
  • 重构代码或样式 / Refactor code or style
  • 测试相关 / Test related
  • 其他 / Other

🔗 相关 Issue / Related Issue

💡 需求背景和解决方案 / Background or solution

📝 更新日志 / Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

@vercel
Copy link
vercel bot commented May 26, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dumi ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 26, 2023 0:01am

@dream2023 dream2023 changed the title chore: Update types.ts chore: 修复 ThemeConfig 的 socialLinks，它不应该是必选的 May 26, 2023
@PeachScript PeachScript changed the title chore: 修复 ThemeConfig 的 socialLinks，它不应该是必选的 fix: socialLinks theme config should be optional May 27, 2023
PeachScript
PeachScript approved these changes May 27, 2023
View reviewed changes
Copy link
Member
@PeachScript PeachScript left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@PeachScript PeachScript merged commit bd3f4b2 into umijs:master May 27, 2023
@PeachScript PeachScript changed the title fix: socialLinks theme config should be optional fix: socialLinks theme config type should be optional May 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeachScript PeachScript PeachScript approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dream2023 @PeachScript
0