-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat: add nprogress when switch page #1648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
afc163
commented
May 9, 2023
8000
好了,等 CI。 |
afc163
commented
May 10, 2023
@@ -84,6 +84,13 @@ dumi 内置了一套完善的默认主题,默认主题的呈现效果与 dumi | |||
|
|||
是否开启 RTL 切换,配置为 `true` 时导航栏会展示 RTL 按钮,用于将站点文本阅读方向切换为『从右到左』,通常在站点用户群体中有使用希伯来语或阿拉伯语时启用。 | |||
|
|||
### nprogress (v2.1.23+) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个 v2.1.23+ 必须得加,否则切到这个页面会挂。
因为 nprogress
标题会生成 id="nprogress"
的元素,所以会抢 nprogress 的 dom 。
预览效果好酷 👍 |
PeachScript
reviewed
May 10, 2023
PeachScript
reviewed
May 10, 2023
PeachScript
approved these changes
May 11, 2023
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个变动的性质是?/ What is the nature of this change?
🔗 相关 Issue / Related Issue
close #1637
💡 需求背景和解决方案 / Background or solution
themeConfig: { hd: { rules: [] }, rtl: true, name: 'dumi', logo: 'https://gw.alipayobjects.com/zos/bmw-prod/d3e3eb39-1cd7-4aa5-827c-877deced6b7e/lalxt4g3_w256_h256.png', footer: `Open-source MIT Licensed | Copyright © 2019-present <br /> Powered by self`, prefersColor: { default: 'auto' }, socialLinks: { github: 'https://github.com/umijs/dumi', }, + nprogress: true, },
📝 更新日志 / Changelog
config.themeConfig.nprogress
to enable page switch progress style.