8000 fix: atom parser uses wacher cwd to resolve full path by minwe · Pull Request #1626 · umijs/dumi · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: atom parser uses wacher cwd to resolve full path #1626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2023
Merged

fix: atom parser uses wacher cwd to resolve full path #1626

merged 1 commit into from
Apr 24, 2023

Conversation

minwe
Copy link
Contributor
@minwe minwe commented Apr 23, 2023

🤔 这个变动的性质是？/ What is the nature of this change?

  • 新特性提交 / New feature
  • bug 修复 / Fix bug
  • 样式优化 / Style optimization
  • 代码风格优化 / Code style optimization
  • 性能优化 / Performance optimization
  • 构建优化 / Build optimization
  • 网站、文档、Demo 改进 / Website, documentation, demo improvements
  • 重构代码或样式 / Refactor code or style
  • 测试相关 / Test related
  • 其他 / Other

🔗 相关 Issue / Related Issue

无

💡 需求背景和解决方案 / Background or solution

#1611 中自定义 watch 参数后，resolveDir 仍然用的 cwd，可能造成拼接出来的文件路径不存在。

watcher 里的 file 路径相对于 this.watchArgs.options.cwd，改用 this.watchArgs.options.cwd 可以保证文件路径始终正确。

📝 更新日志 / Changelog

Language Changelog
🇺🇸 English atom parser uses wacher cwd to resolve full path
🇨🇳 Chinese atom parser 使用 watcher 当前目录拼接文件路径

@vercel
Copy link
vercel bot commented Apr 23, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dumi ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 23, 2023 11:36am

PeachScript
PeachScript approved these changes Apr 24, 2023
View reviewed changes
Copy link
Member
@PeachScript PeachScript left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@PeachScript PeachScript merged commit c7b15ff into umijs:master Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeachScript PeachScript PeachScript approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@minwe @PeachScript
0