Bump Intellifire to 4.1.9 #121091
Merged
Bump Intellifire to 4.1.9 #121091
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
79c66cd to
b30ad06
Compare
213599f to
818e6a6
Compare
joostlek
requested changes
Aug 17, 2024
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
c9f22d6 to
84f5bce
Compare
|
Hi, my name is Garrett Kranz and I work for Hearth & Home Technologies. We manufacture the fireplaces and control systems that this integration leverages. We had requested these changes from @jeeftor awhile back to reduce stress on our devices and servers. Is there any way you can help expedite the request? @joostlek |
Co-authored-by: Erik Montnemery <erik@montnemery.com>
Co-authored-by: Erik Montnemery <erik@montnemery.com>
Co-authored-by: Erik Montnemery <erik@montnemery.com>
joostlek
requested changes
Aug 29, 2024
Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
…to intellifire_bump_migrate
joostlek
requested changes
Aug 30, 2024
28837c2 to
ab1427d
Compare
joostlek
approved these changes
Sep 1, 2024
| except LoginException: | ||
| errors["base"] = "api_error" | ||
| LOGGER.error("Invalid credentials for iftapi.net") | ||
| Local control of IntelliFire devices requires that the user download the correct API KEY which is only available on the cloud. Cloud control of the devices requires the user has at least once authenticated against the cloud and a set of cookie variables have been stored locally. |
There was a problem hiding this comment.
Please follow PEP8 for docstrings. Lines should be shorter than 72 characters.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
I had a previous PR #107479 that was closed due to inactivity. The hold up with that PR was trying to figure out if I should do a migration / minor-migration or no migration. Based on reading through the docs I'm going to use a proper migration - as the new configuration is no longer going to be backwards compatible.
As for the contents of the PR
Reason
In preparation for ultimately adding Cloud support to this integration I need to bump the backing library. I've been in touch with the manufacture and they've given me updated guidance on how to fix the backing library. As such this backing library comes with some additional code changes as well.
Update backing lib
The new backing library uses a
UnifiedFireplacewhich has access to both Cloud and Local functions. This PR is only using the local functions but in order to support the new backing-lib we there was some code refactoring that needed to occur.Update to config-flow
Based on discussion with HTT (Home and Hearth technologies) - previous backing library was handling the "login flow" a little wonky. By changing how thats handled - it also gave me the opportunity to simply the config flow.
Sensor updates
Some of the sensors also had to be updated to support the backing-lib changes...
jeeftor/intellifire4py@2.2.2...v4.1.9
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, 10000 web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: