[Gpr_To_Absl_Logging] Migrating from gpr to absl logging - gpr_set_log_function #36844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctiller
approved these changes
Jun 7, 2024
sourabhsinghs
pushed a commit
to sourabhsinghs/grpc
that referenced
this pull request
Sep 26, 2024
…g_function (grpc#36844) [Gpr_To_Absl_Logging] Migrating from gpr to absl logging - gpr_set_log_function Adding a warning for users of gpr_set_log_function. This function will be deleted soon. grpc/proposal#425 Other options considered ( and discarded ) 1. Using DFATAL instead of ERROR. Discarded this because we still have one critical unit test to clean up before we delete gpr_set_log_function. This test will fail if we use DFATAL. EXPECT_DFATAL macro is not available to be used. 2. Considered making a new absl log sink , and then that log sink should have a function pointer with the same signature as gpr_log_func. This function pointer can be set from gpr_set_log_function. However if this custom function uses absl from within it, that will cause infinite recursion. Made me drop the idea. Closes grpc#36844 COPYBARA_INTEGRATE_REVIEW=grpc#36844 from tanvi-jagtap:assert_gpr_set_log_function 805de35 PiperOrigin-RevId: 641473969
paulosjca
pushed a commit
to paulosjca/grpc
that referenced
this pull request
Nov 25, 2024
…g_function (grpc#36844) [Gpr_To_Absl_Logging] Migrating from gpr to absl logging - gpr_set_log_function Adding a warning for users of gpr_set_log_function. This function will be deleted soon. grpc/proposal#425 Other options considered ( and discarded ) 1. Using DFATAL instead of ERROR. Discarded this because we still have one critical unit test to clean up before we delete gpr_set_log_function. This test will fail if we use DFATAL. EXPECT_DFATAL macro is not available to be used. 2. Considered making a new absl log sink , and then that log sink should have a function pointer with the same signature as gpr_log_func. This function pointer can be set from gpr_set_log_function. However if this custom function uses absl from within it, that will cause infinite recursion. Made me drop the idea. Closes grpc#36844 COPYBARA_INTEGRATE_REVIEW=grpc#36844 from tanvi-jagtap:assert_gpr_set_log_function 805de35 PiperOrigin-RevId: 641473969
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Gpr_To_Absl_Logging] Migrating from gpr to absl logging - gpr_set_log_function
Adding a warning for users of gpr_set_log_function.
This function will be deleted soon.
grpc/proposal#425
Other options considered ( and discarded )