8000 [Python O11y] Implement CSM observability for Python by XuanWang-Amos · Pull Request #36557 · grpc/grpc · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Python O11y] Implement CSM observability for Python #36557

Closed
wants to merge 28 commits into from
Closed

[Python O11y] Implement CSM observability for Python #36557

wants to merge 28 commits into from

Conversation

XuanWang-Amos
Copy link
Contributor
@XuanWang-Amos XuanWang-Amos commented May 7, 2024 •
edited
Loading

Implement Python CSM observability.

Design: go/grpc-python-opentelemetry

@XuanWang-Amos XuanWang-Amos added the release notes: yes Indicates if PR needs to be in release notes label May 7, 2024
@XuanWang-Amos XuanWang-Amos requested a review from gnossen May 17, 2024 18:05
@XuanWang-Amos XuanWang-Amos marked this pull request as ready for review May 17, 2024 18:06
@XuanWang-Amos XuanWang-Amos changed the title [Python O11y] Csm o11y [Python O11y] Implement CSM observability for Python May 17, 2024
gnossen
gnossen reviewed May 21, 2024
View reviewed changes
Copy link
Contributor
@gnossen gnossen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First batch of comments. Not a full review yet.

@XuanWang-Amos
Copy link
Contributor Author

@gnossen PTALA

gnossen
gnossen approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor
@gnossen gnossen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo comments. Sorry for the long turnaround time on this. This is complex stuff and great code. Amazing job pushing this through, Xuan!

sourabhsinghs pushed a commit to sourabhsinghs/grpc that referenced this pull request Sep 26, 2024
@XuanWang-Amos @sourabhsinghs
[Python O11y] Implement CSM observability for Python (grpc#36557)
38612d2 
Implement Python CSM observability.

Design: [go/grpc-python-opentelemetry](http://goto.google.com/grpc-python-opentelemetry)
<!--

If you know who should review your pull request, please assign it to that
person, otherwise the pull request would get assigned randomly.

If your pull request is for a specific language, please add the appropriate
lang label.

-->

Closes grpc#36557

PiperOrigin-RevId: 639073741
paulosjca pushed a commit to paulosjca/grpc that referenced this pull request Nov 25, 2024
@XuanWang-Amos @paulosjca
[Python O11y] Implement CSM observability for Python (grpc#36557)
c8f0971 
Implement Python CSM observability.

Design: [go/grpc-python-opentelemetry](http://goto.google.com/grpc-python-opentelemetry)
<!--

If you know who should review your pull request, please assign it to that
person, otherwise the pull request would get assigned randomly.

If your pull request is for a specific language, please add the appropriate
lang label.

-->

Closes grpc#36557

PiperOrigin-RevId: 639073741
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yashykt yashykt yashykt left review comments

@zasweq zasweq zasweq left review comments

@gnossen gnossen gnossen approved these changes

Assignees
No one assigned
Labels
bloat/none lang/Python per-call-memory/increase per-channel-memory/neutral release notes: yes Indicates if PR needs to be in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@XuanWang-Amos @gnossen @yashykt @zasweq @grpc-kokoro
0