8000 [reflection] Add v1 reflection by eugeneo · Pull Request #34535 · grpc/grpc · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[reflection] Add v1 reflection #34535

Merged
merged 8 commits into from
Oct 4, 2023
Merged

[reflection] Add v1 reflection #34535

merged 8 commits into from
Oct 4, 2023

Conversation

eugeneo
Copy link
Contributor
@eugeneo eugeneo commented Sep 28, 2023

No description provided.

@eugeneo eugeneo added the release notes: yes Indicates if PR needs to be in release notes label Sep 28, 2023
@eugeneo eugeneo requested a review from veblush September 28, 2023 23:03
veblush
veblush approved these changes Sep 29, 2023
View reviewed changes
Copy link
Contributor
@veblush veblush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Please make sure to verify this in the internal repo before merge.

@eugeneo eugeneo enabled auto-merge (squash) October 3, 2023 16:03
auto-merge was automatically disabled October 4, 2023 18:08

Base branch was modified

@eugeneo eugeneo merged commit 5817f0f into grpc:master Oct 4, 2023
@eugeneo eugeneo deleted the tasks/reflectionv1 branch October 4, 2023 18:10
@copybara-service copybara-service bot added the imported Specifies if the PR has been imported to the internal repository label Oct 4, 2023
ctiller added a commit that referenced this pull request Oct 5, 2023
@ctiller
Revert "[reflection] Add v1 reflection (#34535)"
e688a48 
This reverts commit 5817f0f.
@ctiller ctiller mentioned this pull request Oct 5, 2023
Merged
ctiller added a commit that referenced this pull request Oct 5, 2023
@ctiller
Revert "[reflection] Add v1 reflection" (#34594)
3b0916f 
Reverts #34535
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veblush veblush veblush approved these changes

Assignees

@veblush veblush

Labels
bloat/none imported Specifies if the PR has been imported to the internal repository lang/c++ per-call-memory/neutral per-channel-memory/neutral release notes: yes Indicates if PR needs to be in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eugeneo @veblush @grpc-kokoro
0