[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump cross-spawn #19125

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

maybebot
Copy link
Contributor

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

Addressing Regular expression denial of service bug in dependency. While it might not be critical for ESLint usage it pops up in certain internal tooling that register vulnerabilities in packages

What changes did you make? (Give an overview)

Bump cross-spawn version to 7.0.5

Is there anything you'd like reviewers to focus on?

@maybebot maybebot requested a review from a team as a code owner November 13, 2024 20:26
Copy link
linux-foundation-easycla bot commented Nov 13, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

@eslint-github-bot eslint-github-bot bot added the bug ESLint is working incorrectly label Nov 13, 2024
Copy link
netlify bot commented Nov 13, 2024

Deploy Preview for docs-eslint canceled.

Name Link
🔨 Latest commit d4b5eb5
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/67350b8f38e6ae0008c3c7b0

@mdjermanovic mdjermanovic changed the title fix: bump cross-spawn to address vulerability chore: bump cross-spawn Nov 13, 2024
@eslint-github-bot eslint-github-bot bot added the chore This change is not user-facing label Nov 13, 2024
@mdjermanovic
Copy link
Member

We're using cross-spawn with predefined arguments only so there's no impact on ESLint, but it's fine to bump the version if it helps avoid the warnings.

Copy link
Member
@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit 5ff6c1d into eslint:main Nov 13, 2024
26 checks passed
@RaviVadera
Copy link
RaviVadera commented Nov 19, 2024

@mdjermanovic would it be possible to backport this to current 8.x as maintenance release?

@mdjermanovic
Copy link
Member

ESLint v8.x is EOL so the ESLint team is not making any further changes to it. You can find more details about options for EOL release lines support here: https://eslint.org/version-support/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ESLint is working incorrectly chore This change is not user-facing
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

3 participants