[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/9.0] Fix SG nullability annotations for required and init properties. #108013

Merged
merged 1 commit into from
Sep 19, 2024
Merged

[release/9.0] Fix SG nullability annotations for required and init properties. #108013

merged 1 commit into from
Sep 19, 2024

Conversation

github-actions[bot]
Copy link
Contributor
@github-actions github-actions bot commented Sep 19, 2024 •
edited by eiriktsarpalis
Loading

Backport of #107985 to release/9.0

/cc @eiriktsarpalis

Customer Impact

  • Customer reported
  • Found internally

Per customer report, the STJ source generator is not filling out nullability metadata for members populated using member initializers (either required or init properties).

Regression

  • Yes
  • No

Testing

Added relevant unit testing.

Risk

Low. Updates the source generator to populate a missing property.

@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

@eiriktsarpalis eiriktsarpalis self-assigned this Sep 19, 2024
@eiriktsarpalis eiriktsarpalis added this to the 9.0.0 milestone Sep 19, 2024
@eiriktsarpalis eiriktsarpalis added the Servicing-consider Issue for next servicing release review label Sep 19, 2024
@rbhanda rbhanda added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Sep 19, 2024
carlossanlop
carlossanlop approved these changes Sep 19, 2024
View reviewed changes
Copy link
Member
@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved in Tactics

@carlossanlop carlossanlop merged commit ce51262 into release/9.0 Sep 19, 2024
86 of 89 checks passed
@carlossanlop carlossanlop deleted the backport/pr-107985-to-release/9.0 branch September 19, 2024 18:09
@github-actions github-actions bot locked and limited conversation to collaborators Oct 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@carlossanlop carlossanlop carlossanlop approved these changes

@eiriktsarpalis eiriktsarpalis Awaiting requested review from eiriktsarpalis

@jozkee jozkee Awaiting requested review from jozkee

@krwq krwq Awaiting requested review from krwq

@jeffhandley jeffhandley Awaiting requested review from jeffhandley

Assignees

@eiriktsarpalis eiriktsarpalis

Labels
area-System.Text.Json Servicing-approved Approved for servicing release
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@carlossanlop @eiriktsarpalis @rbhanda