use cached blob statter in ManifestService if available #4595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
reviewed
Mar 11, 2025
registry/storage/registry.go
Outdated
Comment on lines
8
to
11
| "github.com/distribution/reference" | ||
|
|
||
| "github.com/distribution/distribution/v3" | ||
| "github.com/distribution/distribution/v3/registry/storage/cache" | ||
| storagedriver "github.com/distribution/distribution/v3/registry/storage/driver" | ||
| "github.com/distribution/reference" |
There was a problem hiding this comment.
Did we change the convention for grouping in general? If not, then it's better to keep this separate, so that the commits don't make unrelated changes.
There was a problem hiding this comment.
That was my default format settings, didn't notice, thanks, reverted this change
| "github.com/distribution/reference" | ||
| "github.com/opencontainers/go-digest" | ||
| "github.com/opencontainers/image-spec/specs-go" | ||
| v1 "github.com/opencontainers/image-spec/specs-go/v1" | ||
|
|
||
| "github.com/distribution/distribution/v3" |
Comment on lines
651
to
655
| func createManifestListDescriptor(t *testing.T, testname string, manifest distribution.Manifest, platformSpec *manifestlist.PlatformSpec) manifestlist.ManifestDescriptor { | ||
| func createManifestListDescriptor( | ||
| t *testing.T, testname string, manifest distribution.Manifest, platformSpec *manifestlist.PlatformSpec, | ||
| ) manifestlist.ManifestDescriptor { |
There was a problem hiding this comment.
This one as well (I think this is only a formatting change, correct?).
davidspek
approved these changes
Mar 11, 2025
|
@Ollegio can you squash? |
Signed-off-by: Oleg Gnusarev <ognusarev@mts.ru>
483133f to
b30274f
Compare
|
@milosgajdos ok, done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4569, #3322