Comparing changes
Open a pull request
- 17 commits
- 9 files changed
- 2 contributors
Commits on Nov 1, 2024
-
-
Merge pull request #333 from dtolnay/nonegroup
Preserve None-delimited groups inside format args
-
Merge pull request #334 from dtolnay/underscorevar
Remove format var parsing workaround that targeted rustc 1.40 and older
Commits on Nov 2, 2024
-
-
Add regression test for issue 335
error[E0277]: `PathBuf` doesn't implement `std::fmt::Display` --> tests/test_expr.rs:105:14 | 104 | #[derive(Error, Debug)] | ----- in this derive macro expansion 105 | #[error("{A} {b}", b = &0 as &dyn Trait<i32, A = i32>)] | ^^^ `PathBuf` cannot be formatted with the default formatter; call `.display()` on it | = help: the trait `std::fmt::Display` is not implemented for `PathBuf` = note: in format strings you may be able to use `{:?}` (or {:#?} for pretty-print) instead = note: call `.display()` or `.to_string_lossy()` to safely print paths, as they may contain non-Unicode data = note: this error originates in the macro `$crate::format_args` which comes from the expansion of the derive macro `Error` (in Nightly builds, run with -Z macro-backtrace for more info) -
-
-
Ignore enum_glob_use pedantic clippy lint
warning: usage of wildcard import for enum variants --> impl/src/scan_expr.rs:1:12 | 1 | use self::{Action::*, Input::*}; | ^^^^^^^^^ help: try: `Action::{DecDepth, Finish, IncDepth, SetState}` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_glob_use = note: `-W clippy::enum-glob-use` implied by `-W clippy::pedantic` = help: to override `-W clippy::pedantic` add `#[allow(clippy::enum_glob_use)]` warning: usage of wildcard import for enum variants --> impl/src/scan_expr.rs:1:23 | 1 | use self::{Action::*, Input::*}; | ^^^^^^^^ help: try: `Input::{CanBeginExpr, ConsumeAny, ConsumeBinOp, ConsumeBrace, ConsumeDelimiter, ConsumeIdent, ConsumeLifetime, ConsumeLiteral, ConsumeNestedBrace, Empty, ExpectPath, ExpectTurbofish, ExpectType, Keyword, Otherwise, Punct}` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_glob_use -
Merge pull request #337 from dtolnay/scan
More robust scanning for fmt argument expressions
Commits on Nov 3, 2024
-
-
Merge pull request #339 from dtolnay/fullexpr
Use syn's real expression parser if it has full syntax support
-
Ignore expected unnecessary_wraps pedantic clippy lint
warning: this function's return value is unnecessarily wrapped by `Result` --> impl/src/fmt.rs:122:1 | 122 | / fn explicit_named_args(input: ParseStream) -> Result<Set<Ident>> { 123 | | let ahead = input.fork(); 124 | | if let Ok(set) = try_explicit_named_args(&ahead) { 125 | | input.advance_to(&ahead); ... | 136 | | Ok(Set::new()) 137 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_wraps = note: `-W clippy::unnecessary-wraps` implied by `-W clippy::pedantic` = help: to override `-W clippy::pedantic` add `#[allow(clippy::unnecessary_wraps)]` help: remove `Result` from the return type... | 122 | fn explicit_named_args(input: ParseStream) -> std::collections::BTreeSet<proc_macro2::Ident> { | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ help: ...and then change returning expressions | 126 ~ return set; 127 | } ... 131 | input.advance_to(&ahead); 132 ~ return set; 133 | } 134 | 135 | input.parse::<TokenStream>().unwrap(); 136 ~ Set::new() | -
Merge pull request #340 from dtolnay/fallbackscan
Add infallible expr scanner fallback for scanning invalid code
-
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 1.0.66...1.0.67