8000 Fix strpos deprecation notice by homersimpsons · Pull Request #11310 · composer/composer · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix strpos deprecation notice #11310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 10, 2023
Merged

Fix strpos deprecation notice #11310

merged 1 commit into from
Feb 10, 2023

Conversation

homersimpsons
Copy link
@homersimpsons homersimpsons commented Feb 9, 2023

I do not exactly know the minimum reproduction, but I had this notice when executing composer. This fix the notice without altering the behaviour.

Deprecation Notice: strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated in composer/src/Composer/DependencyResolver/SolverProblemsException.php:80
Copy link
Contributor
@stof stof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this matches the way this is handle in 2.x

However, any reason you are still using Composer 1.x ?

@homersimpsons
Copy link
Author

However, any reason you are still using Composer 1.x ?

I do have some plugin incompatibilities that forbid me to use composer 2, furthermore upgrading those projects is not really relevant.

@stof
Copy link
Contributor
stof commented Feb 9, 2023

Given that support for composer 1.x is deprecated in packagist.org, it might still be relevant to upgrade (after all, you decided to upgrade PHP for those projects, otherwise you would not care about the deprecation reported in PHP 8.1+).

Note that I don't know what the policy of @Seldaek and @naderman is regarding patches submitted against the 1.x branch.

@Seldaek Seldaek added this to the 1.10 milestone Feb 10, 2023
@Seldaek Seldaek merged commit 1997bb8 into composer:1.10 Feb 10, 2023
@Seldaek
Copy link
Member
Seldaek commented Feb 10, 2023

I'll merge this as you did it so why not, but yeah we're not really maintaining 1.10 beyond critical security fixes, and new-PHP support is definitely not on the table, you should rely on v2 for that, or if you're stuck on an old project with old deps then most likely you're better off also using an old PHP.

@homersimpsons homersimpsons deleted the fix/strpos-deprecation-notice branch February 10, 2023 18:20
@homersimpsons
Copy link
Author

Thank you for the merge :)

I understand there won't be new-PHP support for composer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0