Add Bun example #1456
Merged
Add Bun example #1456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshmgross
reviewed
Oct 3, 2024
examples.md
Outdated
| path: | | ||
| ~\.deno | ||
| ~\AppData\Local\deno | ||
| key: ${{ runner.os }}-deno-${{ hashFiles('**/deps.ts') }} |
There was a problem hiding this comment.
Does Bun on Windows not have a lockfile?
There was a problem hiding this comment.
Guilty of copy/paste. Fixed it!
joshmgross
approved these changes
Oct 7, 2024
PaulRBerg
reviewed
Apr 3, 2025
Comment on lines
+50
to
+51
| path: | | ||
| ~/.bun/install/cache |
There was a problem hiding this comment.
Why not add node_modules to the list of paths, @idleberg @joshmgross?
There was a problem hiding this comment.
@PaulRBerg node_modules with Bun is just hardlinks to the aforementioned ~/.bun/install/cache like PNPM to use less space on disk.
However Bun is usually faster than the cache system, so I wouldn't recommend using it: oven-sh/setup-bun#14 (comment)
There was a problem hiding this comment.
haha interesting, thanks for your answer!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: