8000 Explicit use bash for Windows by Olegt0rr · Pull Request #1377 · actions/cache · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Explicit use bash for Windows #1377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 31, 2024
Merged

Explicit use bash for Windows #1377

merged 2 commits into from
Jul 31, 2024

Conversation

Olegt0rr
Copy link
Contributor
@Olegt0rr Olegt0rr commented Apr 16, 2024 •
edited
Loading

Description

Windows runners use PowerShell by default, so provided docs are not relevant for this os.

Motivation and Context

Fixes #1220

How Has This Been Tested?

Tested here: aio-libs/aiohttp#8339

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (add or update README or docs)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Olegt0rr Olegt0rr requested a review from a team as a code owner April 16, 2024 00:23
@Olegt0rr
Copy link
Contributor Author

@joshmgross
@Babbz86
@eggyhead

Please, set someone to assignee/reviewer
let's close an issue :D

@joshmgross joshmgross enabled auto-merge (squash) July 31, 2024 16:51
@joshmgross joshmgross merged commit e47d9f9 into actions:main Jul 31, 2024
13 checks passed
@Olegt0rr Olegt0rr deleted the bash-for-windows branch August 3, 2024 07:45
siddhantdange pushed a commit to buildpulse/cache that referenced this pull request Oct 4, 2024
@Olegt0rr @joshmgross @siddhantdange
Explicit use bash for Windows (actions#1377)
459c95c 
Co-authored-by: Josh Gross <joshmgross@github.com>
@prolic prolic mentioned this pull request Oct 7, 2024
Merged
@renovate renovate bot mentioned this pull request Oct 8, 2024
Merged
1 task
@bossOfCode bossOfCode mentioned this pull request Oct 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mustafaalqaysy Mustafaalqaysy Mustafaalqaysy left review comments

@joshmgross joshmgross joshmgross approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

examples: "Using pip to get cache location" does not work with WIndows PowerShell (the default)
3 participants
@Olegt0rr @joshmgross @Mustafaalqaysy
0