| MSuijkerbuijk_WMF | |
| Jul 31 2024, 4:18 PM |
| F57362190: IMG_3260.PNG | |
| Aug 30 2024, 11:35 PM |
| F57358995: Screenshot 2024-08-30 at 12.12.20 PM.png | |
| Aug 30 2024, 4:13 PM |
From Sam: We saw significant wins from some copy changes to the pre-payment monthly convert element in banners in December; but we haven't tried them in post-payment, yet.
Creative for variant : create a variant with the copy in this link
Timeline: ideally, we'd want to test it this August.
Adding here the[[ https://app.asana.com/0/1206546120578017/1207175537023431 | Asana task ]]for this variant.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Add monthly convert variant 15 | mediawiki/extensions/DonationInterface | master | +30 -0 |
@MSuijkerbuijk_WMF Question on this, for $2.00 vs $2. What would you want it to do with non even amounts like $1.75?
@Cstone We should keep it as control. If I'm not wrong, we show decimals (2.00, 1.75)
Change #1059960 had a related patch set uploaded (by Cstone; author: Cstone):
[mediawiki/extensions/DonationInterface@master] Add monthly convert variant 15
Change #1059960 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Add monthly convert variant 15
@MSuijkerbuijk_WMF this is available for testing at
To see the convert dialog without making a donation, you can use
Hi @Ejegg It looks good, the only change I don't see implemented is the rounding up to $2.00 note that Sam had in there. Let me know if there is any issue with that.
Please once done, let me know and I'll share it with the team.
Hi @Ejegg , I am excited to test this! I and the banner team will test it out and I'll followup promptly if we see any technical issues.
I'll note one visual issue where the WMF logo comes through the white background of the mc-modal container.
Hi @Ejegg I found one additional visual issue when using a mobile browser (safari on iOS) where the buttons go outside the dialog boundaries.
See image attached
@MSuijkerbuijk_WMF on this comment, with the rounding up do you mean that the amounts would all be even? They are set in a different place but we can change them in the variant too. There are the current amounts: https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/DonationInterface/+/refs/heads/master/extension.json#879
Hi @Ejegg , I am excited to test this! I and the banner team will test it out and I'll followup promptly if we see any technical issues.
I'll note one visual issue where the WMF logo comes through the white background of the mc-modal container.
Looks like this has been a longstanding modal bug, I created a new phab for it here T374074: Foundation logo overlapping monthly convert modal in smaller screen sizes
@Cstone We should show the numbers and decimals in the same way we do in control, so no need to change, just make sure we are not changing amounts or how we show amounts. Thanks
Hi @Ejegg I found one additional visual issue when using a mobile browser (safari on iOS) where the buttons go outside the dialog boundaries.
See image attached
@RLopez-WMF I wasn't able to replicate this on my test iPhone, could you add in what version of safari and what resolution you saw this in?
@Cstone i am using an iPhone mini and the screen size is 375 x 812px
The Safari version is 17.6
Let me know if that helps
Marking as high priority as Online Fundraising would like to take advantage of it for some testing early next week.
@spatton the two issues found here are longstanding bugs and not because of the variant, I made separate phabs for them but is the variant itself good otherwise?
Logo overlap - T374074: Foundation logo overlapping monthly convert modal in smaller screen sizes
Button escape on small screens - T375545: Monthly convert buttons leave modal area on smaller phone screens