Description

Newly added images in galleries always have |alt= (empty alt) in wikitext after saving the changes.

(I noticed this while testing changes for T273505)

Details

	Subject	Repo	Branch	Lines +/-
	Start altText as null to avoid empty alt for new gallery images	mediawiki/extensions/VisualEditor	master	+2 -2

Mentioned In: T368415: For gallery images "use the caption as the alternative text" checkbox must not be offered
Mentioned Here: T273505: Merge mw:Image|mw:Audio|mw:Video into a single mw:File

ppelberg moved this task from To Triage to Triaged on the VisualEditor board.

Hmm, I wonder if it has something to do with https://github.com/wikimedia/parsoid/commit/153c47accb57307be2eab78f27fe242d1803e18c

Nah, it predates that. VE is setting an empty attribute alt="". It needs to distinguish better internally null vs empty string.

Change 811391 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/extensions/VisualEditor@master] Start altText as null to avoid empty alt for new gallery images

Change 811391 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Start altText as null to avoid empty alt for new gallery images

Arlolra closed this task as Resolved.Jul 26 2022, 8:16 PM

Arlolra claimed this task.

matmarex added a project: Editing QA.

✅ Newly added images in galleries have the expected alt text in wikitext after saving changes

When the caption is used as the alternative text

ppelberg closed this task as Resolved.Aug 4 2022, 12:55 AM

	F35365129: Screenshot 2022-07-31 at 00.01.10.png
	Jul 30 2022, 11:07 PM

	F35365126: Screenshot 2022-07-30 at 23.58.16.png
	Jul 30 2022, 11:07 PM