[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Page MenuHomePhabricator
Create Task
Maniphest T310623

Newly added images in galleries are invisible
Closed, ResolvedPublic
Actions

Description

Newly added images in galleries are invisible. (The correct image is used in the dialog and after saving.)

image.png (2×3 px, 281 KB)

(I noticed this while testing changes for T273505)

Details

SubjectRepoBranchLines +/-
Gallery image: Use thumbUrl if src is not set (new images)mediawiki/extensions/VisualEditormaster+3 -1
Customize query in gerrit

Related Objects

Event Timeline

matmarex created this task.Jun 14 2022, 2:32 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 14 2022, 2:32 PM
ppelberg subscribed.Jun 14 2022, 3:29 PM
matmarex added a subscriber: Esanders.Jun 14 2022, 7:17 PM

Caused by rEVEDda8de2e50997: GalleryDialog: Use correct src attribute when rebuilding DOM

ppelberg added a project: Editing-team (Kanban Board).Jun 16 2022, 3:29 PM
ppelberg moved this task from Incoming to Ready to Be Worked On on the Editing-team (Kanban Board) board.
ppelberg moved this task from To Triage to Triaged on the VisualEditor board.
Esanders claimed this task.Jul 1 2022, 12:14 PM
Esanders added a project: Regression.
Esanders moved this task from Ready to Be Worked On to Doing on the Editing-team (Kanban Board) board.
gerritbot added a comment.Jul 1 2022, 12:17 PM

Change 810329 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] Gallery image: Use thumbUrl if src is not set (new images)

https://gerrit.wikimedia.org/r/810329

gerritbot added a project: Patch-For-Review.Jul 1 2022, 12:17 PM
gerritbot added a comment.Jul 1 2022, 10:33 PM

Change 810329 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Gallery image: Use thumbUrl if src is not set (new images)

https://gerrit.wikimedia.org/r/810329

matmarex moved this task from Doing to QA on the Editing-team (Kanban Board) board.Jul 1 2022, 11:18 PM
matmarex added a project: Editing QA.
Maintenance_bot removed a project: Patch-For-Review.Jul 1 2022, 11:30 PM
EAkinloose edited projects, added Verified; removed Editing QA.Jul 4 2022, 11:19 AM
EAkinloose subscribed.

All good. See

Screenshot 2022-07-04 at 12.18.18.png (392×1 px, 32 KB)

EAkinloose moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.Jul 4 2022, 11:19 AM
ppelberg closed this task as Resolved.Jul 8 2022, 12:48 AM
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.21; 2022-07-18).Jul 12 2022, 12:02 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits