More Web Proxy on the site http://driver.im/

Maniphest T305270

Menus: link-html does not work with personal tools menu
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdlrobson
	Apr 1 2022, 7:23 PM

Tags

Referenced Files

None

Subscribers

Description

While working on https://github.com/jdlrobson/FemiwikiSkin/commit/5d5dda804d828dc1f2f2b5fc44a8916e06355321 I noticed two things

When setting text to an empty string, and using text-wrapper an empty element is output to elements.
When setting link-html on a menu item, it renders for all menus except the personal tools menu. This is because personal tools uses a different code path.

Details

	Subject	Repo	Branch	Lines +/-
	[Skins] Add test and fix edge cases for Skin methods	mediawiki/core	master	+117 -13

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Jdlrobson	T299456 Make Skin::getPortletData private
		Resolved		Jdlrobson	T305270 Menus: link-html does not work with personal tools menu

Event Timeline

Jdlrobson created this task.Apr 1 2022, 7:23 PM

Restricted Application added subscribers: Lens0021, Aklapper. · View Herald TranscriptApr 1 2022, 7:23 PM

Jdlrobson moved this task from Backlog to Menus 2.0 on the MediaWiki-Core-Skin-Architecture board.Apr 1 2022, 7:23 PM

Jdlrobson edited projects, added MediaWiki-Core-Skin-Architecture (Menus 2.0); removed MediaWiki-Core-Skin-Architecture.

Change 776055 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] [Skins] Add test and fix edge cases for Skin methods

https://gerrit.wikimedia.org/r/776055

gerritbot added a project: Patch-For-Review.Apr 1 2022, 7:23 PM

Jdlrobson mentioned this in T299456: Make Skin::getPortletData private.Apr 1 2022, 7:24 PM

Aklapper added a parent task: T299456: Make Skin::getPortletData private.Apr 2 2022, 12:37 PM

Change 776055 merged by jenkins-bot:

[mediawiki/core@master] [Skins] Add test and fix edge cases for Skin methods

https://gerrit.wikimedia.org/r/776055

Maintenance_bot removed a project: Patch-For-Review.Apr 5 2022, 2:30 PM

Jdlrobson moved this task from Backlog to Menu prep work on the MediaWiki-Core-Skin-Architecture (Menus 2.0) board.Apr 5 2022, 2:39 PM

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.7; 2022-04-11).Apr 5 2022, 3:00 PM

Thanks!