[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Page MenuHomePhabricator
Create Task
Maniphest T305169

TypeError: Argument 2 passed to WikitextContentHandler::getDataForSearchIndex() must be an instance of ParserOutput, null given, called in /srv/mediawiki/php-1.39.0-wmf.5/extensions/CirrusSearch/includes/BuildDocument/ParserOutputPageProperties.php on line 88
Closed, ResolvedPublic3 Estimated Story PointsPRODUCTION ERROR
Actions

Description

Error
normalized_message
[{reqId}] {exception_url}   TypeError: Argument 2 passed to WikitextContentHandler::getDataForSearchIndex() must be an instance of ParserOutput, null given, called in /srv/mediawiki/php-1.39.0-wmf.5/extensions/CirrusSearch/includes/BuildDocument/ParserOut
exception.trace
from /srv/mediawiki/php-1.39.0-wmf.5/includes/content/WikitextContentHandler.php(152)
#0 /srv/mediawiki/php-1.39.0-wmf.5/extensions/CirrusSearch/includes/BuildDocument/ParserOutputPageProperties.php(88): WikitextContentHandler->getDataForSearchIndex(WikiPage, NULL, CirrusSearch\CirrusSearch)
#1 /srv/mediawiki/php-1.39.0-wmf.5/extensions/CirrusSearch/includes/BuildDocument/ParserOutputPageProperties.php(68): CirrusSearch\BuildDocument\ParserOutputPageProperties->finalizeReal(Elastica\Document, WikiPage, ParserCache, CirrusSearch\CirrusSearch)
#2 /srv/mediawiki/php-1.39.0-wmf.5/extensions/CirrusSearch/includes/BuildDocument/BuildDocument.php(171): CirrusSearch\BuildDocument\ParserOutputPageProperties->finalize(Elastica\Document, Title)
#3 /srv/mediawiki/php-1.39.0-wmf.5/extensions/CirrusSearch/includes/DataSender.php(250): CirrusSearch\BuildDocument\BuildDocument->finalize(Elastica\Document)
#4 /srv/mediawiki/php-1.39.0-wmf.5/extensions/CirrusSearch/includes/Job/ElasticaWrite.php(137): CirrusSearch\DataSender->sendData(string, array)
#5 /srv/mediawiki/php-1.39.0-wmf.5/extensions/CirrusSearch/includes/Job/JobTraits.php(136): CirrusSearch\Job\ElasticaWrite->doJob()
#6 /srv/mediawiki/php-1.39.0-wmf.5/extensions/CirrusSearch/includes/Updater.php(446): CirrusSearch\Job\CirrusGenericJob->run()
#7 /srv/mediawiki/php-1.39.0-wmf.5/extensions/CirrusSearch/includes/Updater.php(221): CirrusSearch\Updater->pushElasticaWriteJobs(array, Closure)
#8 /srv/mediawiki/php-1.39.0-wmf.5/extensions/CirrusSearch/includes/Updater.php(79): CirrusSearch\Updater->updatePages(array, integer)
#9 /srv/mediawiki/php-1.39.0-wmf.5/extensions/CirrusSearch/includes/Job/LinksUpdate.php(51): CirrusSearch\Updater->updateFromTitle(Title)
#10 /srv/mediawiki/php-1.39.0-wmf.5/extensions/CirrusSearch/includes/Job/JobTraits.php(136): CirrusSearch\Job\LinksUpdate->doJob()
#11 /srv/mediawiki/php-1.39.0-wmf.5/extensions/EventBus/includes/JobExecutor.php(79): CirrusSearch\Job\CirrusTitleJob->run()
#12 /srv/mediawiki/rpc/RunSingleJob.php(76): MediaWiki\Extension\EventBus\JobExecutor->execute(array)
#13 {main}
Notes
  • Low frequency: Happened four or so times in the past week
  • exclusively on job runners

Details

Request URL
https://jobrunner.discovery.wmnet/rpc/RunSingleJob.php
SubjectRepoBranchLines +/-
Fail cleanly when the the ParserOutput cannot be retrievedmediawiki/extensions/CirrusSearchmaster+46 -9
Clarify the return type of ContentHandler::getParserOutputForIndexing()mediawiki/coremaster+3 -2
Customize query in gerrit

Event Timeline

thcipriani created this task.Mar 31 2022, 3:50 PM
Restricted Application added a project: Discovery-Search. · View Herald TranscriptMar 31 2022, 3:50 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
thcipriani moved this task from Untriaged to Mar 2022 on the Wikimedia-production-error board.Mar 31 2022, 3:50 PM
• MPhamWMF moved this task from needs triage to Current work on the Discovery-Search board.Apr 4 2022, 3:30 PM
• MPhamWMF edited projects, added Discovery-Search (Current work); removed Discovery-Search.
• MPhamWMF set the point value for this task to 3.Apr 4 2022, 3:54 PM
• MPhamWMF moved this task from Incoming to Ready for Dev -- SWE on the Discovery-Search (Current work) board.
dcausse claimed this task.Apr 5 2022, 7:26 AM
dcausse moved this task from Ready for Dev -- SWE to In Progress on the Discovery-Search (Current work) board.
gerritbot added a comment.Apr 5 2022, 8:39 AM

Change 777301 had a related patch set uploaded (by DCausse; author: DCausse):

[mediawiki/core@master] Clarify the return type of ContentHandler::getParserOutputForIndexing()

https://gerrit.wikimedia.org/r/777301

gerritbot added a project: Patch-For-Review.Apr 5 2022, 8:39 AM
gerritbot added a comment.Apr 5 2022, 1:28 PM

Change 777352 had a related patch set uploaded (by DCausse; author: DCausse):

[mediawiki/extensions/CirrusSearch@master] Fails cleanly when the the ParserOutput cannot be retrieved

https://gerrit.wikimedia.org/r/777352

dcausse moved this task from In Progress to Needs review on the Discovery-Search (Current work) board.Apr 5 2022, 5:34 PM
gerritbot added a comment.Apr 5 2022, 8:12 PM

Change 777301 merged by jenkins-bot:

[mediawiki/core@master] Clarify the return type of ContentHandler::getParserOutputForIndexing()

https://gerrit.wikimedia.org/r/777301

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.7; 2022-04-11).Apr 5 2022, 9:00 PM
gerritbot added a comment.Apr 11 2022, 6:03 PM

Change 777352 merged by jenkins-bot:

[mediawiki/extensions/CirrusSearch@master] Fail cleanly when the the ParserOutput cannot be retrieved

https://gerrit.wikimedia.org/r/777352

Maintenance_bot removed a project: Patch-For-Review.Apr 11 2022, 6:30 PM
EBernhardson moved this task from Needs review to To Be Deployed on the Discovery-Search (Current work) board.Apr 11 2022, 10:10 PM
EBernhardson moved this task from To Be Deployed to Needs Reporting on the Discovery-Search (Current work) board.Apr 29 2022, 8:07 PM
Gehel closed this task as Resolved.May 9 2022, 9:24 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits