[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Page MenuHomePhabricator
Create Task
Maniphest T305110

Template:Short description is not visible, but not treated as an invisible template
Closed, ResolvedPublic
Actions

Assigned To
ppelberg
Authored By
Esanders
Mar 30 2022, 9:47 PM
Tags
Referenced Files
F35075158: Screenshot 2022-04-29 at 23.22.23.png
Apr 29 2022, 10:26 PM
F35075162: Screenshot 2022-04-29 at 23.22.59.png
Apr 29 2022, 10:26 PM
F35075167: Screenshot 2022-04-29 at 23.23.43.png
Apr 29 2022, 10:26 PM
F35030358: image.png
Mar 30 2022, 9:47 PM
F35030362: image.png
Mar 30 2022, 9:47 PM
F35030356: image.png
Mar 30 2022, 9:47 PM
Subscribers
Aklapper
EAkinloose
Esanders
Izno
matmarex

Description

Observe you have selected an invisible template {{Short description}}:

image.png (296×556 px, 27 KB)

Templates which have no visible content should get a template icon placeholder, like {{Use British English}}:

image.png (138×412 px, 9 KB)

The invisible template is also generating block slugs ("Insert paragraph" buttons) either side of it, with no visible indication as to why there are two slugs at the top of the page:

image.png (287×682 px, 52 KB)

Details

SubjectRepoBranchLines +/-
Update VE core submodule to master (86de64d69)mediawiki/extensions/VisualEditormaster+6 -3
Re-apply "Fix for showing "invisible icon" when root node is hidden""VisualEditor/VisualEditormaster+17 -8
Attach VE overlay to DOM while initializingmediawiki/extensions/MobileFrontendmaster+24 -6
Revert "Fix for showing "invisible icon" when root node is hidden"VisualEditor/VisualEditormaster+8 -17
Update VE core submodule to master (ffaefe32c)mediawiki/extensions/VisualEditormaster+1 -1
Fix for showing "invisible icon" when root node is hiddenVisualEditor/VisualEditormaster+17 -8
Customize query in gerrit

Event Timeline

Esanders created this task.Mar 30 2022, 9:47 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 30 2022, 9:47 PM
Esanders added a comment.Mar 30 2022, 9:48 PM

There are two causes of this bug:
Part 1
Our definition of hasRendering in ve.ce.FocusableNode begins with:

ve.ce.FocusableNode.prototype.hasRendering = function () {
	if ( this.$element.text().trim() !== '' ) {
		return true;
	}
	...

We assume that any node that has non-whitespace text content has a rendering, but in this situation the template produces text wrapped in display:none (for accessibility or SEO visibility?).

Part 2
Because of the above mentioned display:none, when we append the invisible icon marker to the CE node, it is also hidden.

gerritbot added a comment.Mar 31 2022, 8:57 PM

Change 775959 had a related patch set uploaded (by Esanders; author: Esanders):

[VisualEditor/VisualEditor@master] Fix for showing "invisible icon" when root node is hidden

https://gerrit.wikimedia.org/r/775959

gerritbot added a project: Patch-For-Review.Mar 31 2022, 8:57 PM
Izno subscribed.Mar 31 2022, 10:51 PM

the template produces text wrapped in display:none (for accessibility or SEO visibility?)

So users can display the short description.

matmarex added a project: Editing-team (Kanban Board).Apr 1 2022, 2:57 PM
matmarex moved this task from To Triage to Triaged on the VisualEditor board.
matmarex moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.Apr 1 2022, 3:01 PM
gerritbot added a comment.Apr 5 2022, 9:24 PM

Change 775959 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Fix for showing "invisible icon" when root node is hidden

https://gerrit.wikimedia.org/r/775959

Maintenance_bot removed a project: Patch-For-Review.Apr 5 2022, 9:30 PM
gerritbot added a comment.Apr 5 2022, 9:43 PM

Change 777447 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (9a60258c5)

https://gerrit.wikimedia.org/r/777447

gerritbot added a project: Patch-For-Review.Apr 5 2022, 9:43 PM
gerritbot added a comment.Apr 6 2022, 8:44 PM

Change 777774 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[VisualEditor/VisualEditor@master] Revert "Fix for showing "invisible icon" when root node is hidden"

https://gerrit.wikimedia.org/r/777774

matmarex subscribed.Apr 6 2022, 8:46 PM

I reverted the fix because it didn't work correctly on mobile, where it caused the icons to be added to every template. Unfortunately I only noticed after merging it. Sorry about the mess with reverts.

gerritbot added a comment.Apr 6 2022, 8:47 PM

Change 777774 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Revert "Fix for showing "invisible icon" when root node is hidden"

https://gerrit.wikimedia.org/r/777774

gerritbot added a comment.Apr 6 2022, 9:05 PM

Change 777447 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (ffaefe32c)

https://gerrit.wikimedia.org/r/777447

matmarex moved this task from Code Review to Blocked / Needs More Work on the Editing-team (Kanban Board) board.Apr 6 2022, 9:06 PM
Maintenance_bot removed a project: Patch-For-Review.Apr 6 2022, 9:30 PM
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.7; 2022-04-11).Apr 6 2022, 10:00 PM
matmarex removed a project: MW-1.39-notes (1.39.0-wmf.7; 2022-04-11).Apr 6 2022, 10:27 PM
gerritbot added a comment.Apr 7 2022, 10:44 AM

Change 778228 had a related patch set uploaded (by Esanders; author: Esanders):

[VisualEditor/VisualEditor@master] Re-apply "Fix for showing "invisible icon" when root node is hidden""

https://gerrit.wikimedia.org/r/778228

gerritbot added a project: Patch-For-Review.Apr 7 2022, 10:44 AM

Change 777807 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/MobileFrontend@master] Attach VE overlay to DOM while initializing

https://gerrit.wikimedia.org/r/777807

ppelberg moved this task from Blocked / Needs More Work to Code Review on the Editing-team (Kanban Board) board.Apr 11 2022, 5:09 PM
gerritbot added a comment.Apr 11 2022, 7:35 PM

Change 777807 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Attach VE overlay to DOM while initializing

https://gerrit.wikimedia.org/r/777807

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.7; 2022-04-11).Apr 11 2022, 8:00 PM
gerritbot added a comment.Apr 19 2022, 8:20 PM

Change 778228 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Re-apply "Fix for showing "invisible icon" when root node is hidden""

https://gerrit.wikimedia.org/r/778228

gerritbot added a comment.Apr 19 2022, 9:25 PM

Change 784327 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (86de64d69)

https://gerrit.wikimedia.org/r/784327

gerritbot added a comment.Apr 20 2022, 11:58 PM

Change 784327 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (86de64d69)

https://gerrit.wikimedia.org/r/784327

ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.9; 2022-04-25); removed MW-1.39-notes (1.39.0-wmf.7; 2022-04-11).Apr 21 2022, 12:00 AM
matmarex moved this task from Code Review to QA on the Editing-team (Kanban Board) board.Apr 21 2022, 1:42 AM
matmarex edited projects, added Editing QA; removed Patch-For-Review.
EAkinloose subscribed.Apr 29 2022, 10:26 PM

The template icon is displayed as a placeholder. This shows up as soon as you land on the page - even before engaging.

Screenshot 2022-04-29 at 23.22.23.png (636×2 px, 198 KB)

Screenshot 2022-04-29 at 23.22.59.png (496×1 px, 148 KB)

Screenshot 2022-04-29 at 23.23.43.png (488×1 px, 174 KB)

EAkinloose edited projects, added Verified; removed Editing QA.Apr 29 2022, 10:26 PM
EAkinloose moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.
ppelberg closed this task as Resolved.May 7 2022, 1:01 AM
ppelberg claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits