[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Page MenuHomePhabricator

Templates which are taller than the viewport try to scroll into view, but fail
Closed, ResolvedPublic

Description

  1. https://en.wikipedia.org/wiki/Heathrow_Airport?veaction=edit&section=19
  2. Set your window height to <1000px height
  3. Click on the template-generated table

Observed:
The window scrolls down to try and fit the template in the viewport.

Expected:
If the template won't fit in the viewport, there's no point scrolling beyond scrolling enough to make room for the context.

On mobile, in particular, auto-scrolling can make for frustrating navigation through the page.

Event Timeline

Change 779070 had a related patch set uploaded (by Bartosz Dziewoński; author: Esanders):

[VisualEditor/VisualEditor@master] Don't attempt to scroll tall selections into view

https://gerrit.wikimedia.org/r/779070

Change 779070 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Don't attempt to scroll tall selections into view

https://gerrit.wikimedia.org/r/779070

Change 779094 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (a0bf00838)

https://gerrit.wikimedia.org/r/779094

Change 779094 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (a0bf00838)

https://gerrit.wikimedia.org/r/779094

This works as expected.
Desktop: See https://photos.app.goo.gl/frmZogQe6TGhYFoE8 (00:14, 00:21, 00:28). Notice how the 2nd and 3rd template scroll into focus but not the first as it doesn't fit in the viewport.
Mobile: See https://photos.app.goo.gl/4C4t8KD61J8eqRWh7 (00:01, 00:11).

ppelberg claimed this task.