[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Page MenuHomePhabricator
Create Task
Maniphest T305805

Use MainConfigNames constants instead of string literals
Closed, ResolvedPublic
Actions

Description

We currently use string literals for identifying configuration options. This precludes automatic validation. We apparently want to switch to the MainConfigNames constants instead. This will involve lots of manually-reviewed search and replace.

Details

SubjectRepoBranchLines +/-
Use MainConfigNames instead of string literals, #4mediawiki/coremaster+800 -658
Use MainConfigNames instead of string literals, #3mediawiki/coremaster+447 -354
Use MainConfigNames instead of string literalsmediawiki/coremaster+379 -266
Customize query in gerrit

Event Timeline

Simetrical created this task.Apr 10 2022, 3:39 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 10 2022, 3:39 PM
gerritbot added a comment.Apr 10 2022, 3:40 PM

Change 778671 had a related patch set uploaded (by Simetrical; author: Simetrical):

[mediawiki/core@master] Use MainConfigNames instead of string literals

https://gerrit.wikimedia.org/r/778671

gerritbot added a project: Patch-For-Review.Apr 10 2022, 3:40 PM
gerritbot added a comment.Apr 11 2022, 7:19 PM

Change 778671 merged by jenkins-bot:

[mediawiki/core@master] Use MainConfigNames instead of string literals

https://gerrit.wikimedia.org/r/778671

Maintenance_bot removed a project: Patch-For-Review.Apr 11 2022, 7:31 PM
Simetrical added a comment.Apr 14 2022, 7:29 PM

This was part two, but I forgot to add the "Bug" annotation:

https://gerrit.wikimedia.org/r/c/mediawiki/core/+/779894

gerritbot added a comment.Apr 25 2022, 6:34 PM

Change 785913 had a related patch set uploaded (by Simetrical; author: Simetrical):

[mediawiki/core@master] Use MainConfigNames instead of string literals, #3

https://gerrit.wikimedia.org/r/785913

gerritbot added a project: Patch-For-Review.Apr 25 2022, 6:34 PM
gerritbot added a comment.Apr 26 2022, 12:46 PM

Change 785913 merged by jenkins-bot:

[mediawiki/core@master] Use MainConfigNames instead of string literals, #3

https://gerrit.wikimedia.org/r/785913

Maintenance_bot removed a project: Patch-For-Review.Apr 26 2022, 1:31 PM
gerritbot added a comment.Apr 26 2022, 4:03 PM

Change 786345 had a related patch set uploaded (by Simetrical; author: Simetrical):

[mediawiki/core@master] Use MainConfigNames instead of string literals, #4

https://gerrit.wikimedia.org/r/786345

gerritbot added a project: Patch-For-Review.Apr 26 2022, 4:03 PM
gerritbot added a comment.Apr 27 2022, 10:26 AM

Change 786345 merged by jenkins-bot:

[mediawiki/core@master] Use MainConfigNames instead of string literals, #4

https://gerrit.wikimedia.org/r/786345

Maintenance_bot removed a project: Patch-For-Review.Apr 27 2022, 10:30 AM
Simetrical closed this task as Resolved.Apr 28 2022, 12:58 PM

I think this is done in core, at least for now. I'm sure more instances will crop up for a while to come, so it probably deserves checking again sometime in the future.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits