BundleSizeTest for a skin tests the default skin
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Lens0021
	Apr 9 2022, 10:37 AM

Description

List of steps to reproduce:

Install MinervaNeue skin which defines its BundleSizeTest.php and bundlesize.config.json
Install a larger skin than Minerva and set it to the default skin.
Run PHPUnit.

What happens?:

BundleSizeTest.php tests with MediaWikiServices::getInstance()->getMainConfig()->get( 'DefaultSkin' ) skin,
so if the default skin is larger then the target of the test, there is failures: (full log)

1) MediaWiki\Skins\MinervaNeue\Tests\Structure\BundleSizeTest::testBundleSize
skins.minerva.mainMenu.icons is less than 409.6
Failed asserting that 410 is less than 409.60000000000002.

/workspace/src/tests/phpunit/structure/BundleSizeTest.php:59
/workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:467

What should have happened instead?:

There should be no failure.

Software version:

MediaWiki: 1.39 a01dbf1e075f10594729b4ffe927293915344cd6
MinervaNeue: 916e8bc9c1b47eb09f8d032dd5a2e18e3b0ddec2

Details

Subject	Repo	Branch	Lines +/-
phpunit: Implement the new BundleSizeTest::getSkinName()	mediawiki/skins/MinervaNeue	REL1_38	+5 -0
phpunit: Support setting skin context in BundleSizeTest subclasses	mediawiki/core	REL1_38	+8 -1
phpunit: Implement the new BundleSizeTest::getSkinName()	mediawiki/skins/MinervaNeue	master	+5 -0
phpunit: Support setting skin context in BundleSizeTest subclasses	mediawiki/core	master	+8 -1

Customize query in gerrit

Related Objects

Mentioned In: T253582: Let ResourceLoader only register skin modules for the current skin
Mentioned Here: rSMIN916e8bc9c1b4: Localisation updates from https://translatewiki.net.
rMWa01dbf1e075f: Merge "Use spaces in page names instead of underscores for cross-wiki uploads"

Event Timeline

Lens0021 created this task.Apr 9 2022, 10:37 AM

Restricted Application added a project: Performance-Team. · View Herald TranscriptApr 9 2022, 10:37 AM

Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald Transcript

Lens0021 renamed this task from Setting SkinOOUIThemes increases the bundlesize of other skin's OOUIIconPackModule to BundleSizeTest for a skin tests the default skin.Apr 9 2022, 11:58 AM

Lens0021 removed a project: OOUI.

Lens0021 updated the task description. (Show Details)

Change 778611 had a related patch set uploaded (by Lens0021; author: Lens0021):

[mediawiki/core@master] BundleSizeTest: Give a setting skin name chance to subclasses

https://gerrit.wikimedia.org/r/778611

gerritbot added a project: Patch-For-Review.Apr 9 2022, 12:10 PM

Change 778613 had a related patch set uploaded (by Lens0021; author: Lens0021):

[mediawiki/skins/MinervaNeue@master] BundleSizeTest: Extend ::getSkinName()

https://gerrit.wikimedia.org/r/778613

Lens0021 claimed this task.Apr 9 2022, 12:21 PM

Krinkle moved this task from Inbox, needs triage to Doing: Prio Interrupt on the Performance-Team board.Apr 11 2022, 6:50 PM

Krinkle mentioned this in T253582: Let ResourceLoader only register skin modules for the current skin.Apr 12 2022, 12:01 AM

Change 778611 merged by jenkins-bot:

[mediawiki/core@master] phpunit: Support setting skin context in BundleSizeTest subclasses

https://gerrit.wikimedia.org/r/778611

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.7; 2022-04-11).Apr 12 2022, 1:00 AM

Change 778613 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] phpunit: Implement the new BundleSizeTest::getSkinName()

https://gerrit.wikimedia.org/r/778613

Maintenance_bot removed a project: Patch-For-Review.Apr 12 2022, 1:30 AM

ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.8; 2022-04-18); removed MW-1.39-notes (1.39.0-wmf.7; 2022-04-11).Apr 12 2022, 2:00 AM

Lens0021 closed this task as Resolved.Apr 12 2022, 2:14 AM

Change 789166 had a related patch set uploaded (by Lens0021; author: Lens0021):

[mediawiki/skins/MinervaNeue@REL1_38] phpunit: Implement the new BundleSizeTest::getSkinName()

https://gerrit.wikimedia.org/r/789166

Change 789167 had a related patch set uploaded (by Lens0021; author: Lens0021):

[mediawiki/core@REL1_38] phpunit: Support setting skin context in BundleSizeTest subclasses

https://gerrit.wikimedia.org/r/789167

Change 789167 merged by jenkins-bot:

[mediawiki/core@REL1_38] phpunit: Support setting skin context in BundleSizeTest subclasses

https://gerrit.wikimedia.org/r/789167

ReleaseTaggerBot added a project: MW-1.38-notes.Jun 2 2022, 9:00 PM

Change 789166 merged by jenkins-bot: