[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Page MenuHomePhabricator
Create Task
Maniphest T305691

Refactor ContentTranslation backend codebase to properly use dependency injection
Open, LowPublic
Actions

Description

Several services inside ContentTranslation extension do not follow best practices for dependency injection, leading to code smells. Although, there is no immediate need for these services to change, since they have been there for a long time, it is important to remove these bad patterns and properly use dependency injection in hook runner, API modules and other places.

To support this need, the following services should be refactored:

  • ContentTranslation/CategoriesStorageManager
  • ContentTranslation/CorporaLookup
  • ContentTranslation/LoadBalancer
  • ContentTranslation/PreferenceHelper
  • ContentTranslation/SiteMapper
  • ContentTranslation/SuggestionListManager
  • ContentTranslation/Translation
  • ContentTranslation/TranslationStorageManager
  • ContentTranslation/Translator

Details

SubjectRepoBranchLines +/-
CX Backend: Create TranslationStore servicemediawiki/extensions/ContentTranslationmaster+1 K -1 K
CX: Refactor ApiSectionTranslationPublish classmediawiki/extensions/ContentTranslationmaster+93 -52
CX Refactoring: Rename and create service for AbuseFilterCheckmediawiki/extensions/ContentTranslationmaster+224 -176
CX Refactoring: Create TranslationUnitValidator servicemediawiki/extensions/ContentTranslationmaster+106 -62
CX Refactoring: Create service for RestbaseClientmediawiki/extensions/ContentTranslationmaster+123 -57
CX Refactoring: Rename and refactor TranslationStorageManagermediawiki/extensions/ContentTranslationmaster+325 -251
CX Dependency Injection: add Wikibase SettingsArray servicemediawiki/extensions/ContentTranslationmaster+10 -0
CX Dependency Injection: add Wikibase SiteLinkLookup servicemediawiki/extensions/ContentTranslationmaster+12 -0
Customize query in gerrit

Related Objects

Event Timeline

ngkountas created this task.Apr 8 2022, 1:11 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 8 2022, 1:11 PM
ngkountas triaged this task as Low priority.Apr 8 2022, 1:12 PM
gerritbot added a comment.Apr 8 2022, 1:12 PM

Change 777845 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] CX Backend: Create TranslationStore service

https://gerrit.wikimedia.org/r/777845

gerritbot added a project: Patch-For-Review.Apr 8 2022, 1:12 PM
santhosh subscribed.Apr 11 2022, 6:00 AM

Moving to current sprint/quarter since there are efforts on this ticket these days. - For visibility.

@ngkountas Perhaps patches like https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ContentTranslation/+/763181 and https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ContentTranslation/+/763182/5 can be linked to this ticket?

santhosh moved this task from Quarter Backlog to In Progress on the Language-Team (Language-2022-April-June) board.Apr 11 2022, 6:01 AM
gerritbot added a comment.Apr 11 2022, 6:13 AM

Change 763181 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] CX Dependency Injection: add Wikibase SiteLinkLookup service

https://gerrit.wikimedia.org/r/763181

gerritbot added a comment.Apr 11 2022, 6:13 AM

Change 763182 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] CX Dependency Injection: add Wikibase SettingsArray service

https://gerrit.wikimedia.org/r/763182

gerritbot added a comment.Apr 11 2022, 6:54 AM

Change 763181 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX Dependency Injection: add Wikibase SiteLinkLookup service

https://gerrit.wikimedia.org/r/763181

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.7; 2022-04-11).Apr 11 2022, 7:00 AM
gerritbot added a comment.Apr 11 2022, 8:21 AM

Change 763182 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX Dependency Injection: add Wikibase SettingsArray service

https://gerrit.wikimedia.org/r/763182

santhosh assigned this task to ngkountas.Apr 12 2022, 5:35 AM
gerritbot added a comment.Apr 19 2022, 7:33 AM

Change 784087 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] CX Refactoring: Rename and refactor TranslationStorageManager

https://gerrit.wikimedia.org/r/784087

gerritbot added a comment.Apr 19 2022, 7:33 AM

Change 784088 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] CX Refactoring: Create service for RestbaseClient

https://gerrit.wikimedia.org/r/784088

gerritbot added a comment.Apr 19 2022, 7:33 AM

Change 784089 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] CX Refactoring: Rename and create service for AbuseFilterCheck

https://gerrit.wikimedia.org/r/784089

gerritbot added a comment.May 13 2022, 9:49 AM

Change 791566 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] CX Refactoring: Create TranslationUnitValidator service

https://gerrit.wikimedia.org/r/791566

gerritbot added a comment.May 26 2022, 12:12 PM

Change 784087 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX Refactoring: Rename and refactor TranslationStorageManager

https://gerrit.wikimedia.org/r/784087

ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.14; 2022-05-30); removed MW-1.39-notes (1.39.0-wmf.7; 2022-04-11).May 26 2022, 1:00 PM
gerritbot added a comment.May 31 2022, 6:29 AM

Change 784088 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX Refactoring: Create service for RestbaseClient

https://gerrit.wikimedia.org/r/784088

gerritbot added a comment.May 31 2022, 6:42 AM

Change 784089 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX Refactoring: Rename and create service for AbuseFilterCheck

https://gerrit.wikimedia.org/r/784089

gerritbot added a comment.May 31 2022, 6:42 AM

Change 791566 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX Refactoring: Create TranslationUnitValidator service

https://gerrit.wikimedia.org/r/791566

ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.15; 2022-06-06); removed MW-1.39-notes (1.39.0-wmf.14; 2022-05-30).May 31 2022, 7:00 AM
gerritbot added a comment.Jun 8 2022, 2:48 PM

Change 799295 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] CX: Refactor ApiSectionTranslationPublish class

https://gerrit.wikimedia.org/r/799295

Nikerabbit added a project: ContentTranslation.Jun 9 2022, 2:48 PM
Nikerabbit added a project: Developer Productivity.Jun 23 2022, 5:54 AM
gerritbot added a comment.Jun 29 2022, 6:44 AM

Change 799295 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX: Refactor ApiSectionTranslationPublish class

https://gerrit.wikimedia.org/r/799295

Pginer-WMF edited projects, added Language-Team (Language-2022-July-September); removed Language-Team (Language-2022-April-June).Jul 4 2022, 10:56 AM
Pginer-WMF moved this task from Quarter Backlog to In Progress on the Language-Team (Language-2022-July-September) board.
Pginer-WMF moved this task from Needs Triage to Enhancements on the ContentTranslation board.Jul 4 2022, 11:31 AM
ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.21; 2022-07-18); removed MW-1.39-notes (1.39.0-wmf.15; 2022-06-06).Jul 11 2022, 9:01 PM
Pginer-WMF moved this task from In Progress to Quarter Backlog on the Language-Team (Language-2022-July-September) board.Sep 1 2022, 1:13 PM
Pppery edited projects, added Patch-Needs-Improvement, Dependency injection; removed Patch-For-Review.Jun 7 2023, 6:53 PM
Krinkle mentioned this in T343244: PHP Notice: Undefined index: origin.Aug 1 2023, 3:59 PM
ngkountas removed ngkountas as the assignee of this task.Apr 17 2024, 10:35 AM
gerritbot added a comment.Jun 6 2024, 8:38 AM

Change #777845 abandoned by Nik Gkountas:

[mediawiki/extensions/ContentTranslation@master] CX Backend: Create TranslationStore service

Reason:

This patch is pending for review for over 2 years, and given its size I don't expect it to be reviewed at all, since it's not a priority for the Language Team.

https://gerrit.wikimedia.org/r/777845

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits